Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#12810 closed enhancement (fixed)

[patch][ccla] More dojox.geo.charting enhancements

Reported by: cjolif Owned by: Chris Mitchell
Priority: high Milestone: 1.7
Component: Charting Version: 1.6.0
Keywords: 1.7-mobile Cc:
Blocked By: Blocking:


Thanks to Erwan Aullas (IBM, CCLA)

The patch to be attached later contains the following changes. It adds up to already committed #12416.

  • Changed dataStore structure
    • now there must be one dataStore element per map element. That element must have a unique identifier that corresponds to the identifier of the map element in the shape file. It also contains various properties with data values for that map element.
  • The data binding between the map element and the dataStore element (i.e. what property are we looking up to colorize the map element) is specified through the setDataBindingAttribute function on the Map object. For instance, if dataStore elements contain a 'population' property storing the population count for each country on the map :


  • if the property value can not be simply parsed as a number, or needs processing, a dataBindingValueFunction can be set on the Map object through the setDataBindingValueFunction function. It must take the property value as parameter, and return a value to be set on the map element (aka 'Feature' instance)
  • Refactored Mouse and Touch interactors
    • these classes are now public, and their instantiation and installation on the Map component are up to the user. This gives more control on how to interact with the Map component, and also avoids useless dojo requires on different platforms (desktop vs touch devices)
  • Added Map Dijit wrapper
    • the geo.charting.widget.Map class is a Dijit component that embeds a geo.charting.Map and takes care of its configuration according to markup attributes
  • new features on Map component
    • enable/disable tooltips
    • enable/disable color change animation when changing data series
  • Updated 'Map with legend' sample, to match new dataStore format, and also demonstrate dataBindingAttribute use.
  • Updated 'Map with charting" sample. Replaced the DataChart? with regular chart, as the new datastore format was not compatible with DataChart?.
  • Feature class renamed (removed '_'), as it is exposed to the user.
  • many fixes and small improvements this and there..

NOTE: #7782 is a prerequisite for this patch

Attachments (2)

12810.patch (216.8 KB) - added by cjolif 11 years ago.
initial patch
12810.2.patch (217.0 KB) - added by cjolif 11 years ago.
Removed dijit_Templated inheritance from dojox.geo.charting.widget.Legend

Download all attachments as: .zip

Change History (8)

comment:1 Changed 11 years ago by cjolif

obviously please change from defect->enhancement. Sorry.

comment:2 Changed 11 years ago by Adam Peller

Type: defectenhancement

Changed 11 years ago by cjolif

Attachment: 12810.patch added

initial patch

comment:3 Changed 11 years ago by Chris Mitchell

Component: DojoxCharting
Owner: changed from Adam Peller to Chris Mitchell

Changed 11 years ago by cjolif

Attachment: 12810.2.patch added

Removed dijit_Templated inheritance from dojox.geo.charting.widget.Legend

comment:4 Changed 11 years ago by Chris Mitchell

Resolution: fixed
Status: newclosed

(In [24609]) fixes #12810 more geo charting enhancements !strict

comment:5 Changed 11 years ago by bill

Milestone: tbd1.7

comment:6 Changed 11 years ago by Chris Mitchell

(In [24978]) refs #12810 removing dead files from dojox/geo/charting

Note: See TracTickets for help on using tickets.