Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#12803 closed defect (fixed)

gantt chart test case failed

Reported by: JayZ(zhouxiang) Owned by: Adam Peller
Priority: high Milestone: 1.7
Component: Dojox Version: 1.6.0
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by Adam Peller)

dojox.gantt.tests.test_Gantt.html seems not working. It have the following bugs:

  • in FF 3.6.16: handle is undefined (dojo.js line 401)
  • in Chrome 10.0.648.205:
  1. 170 <chrome-devtools://devtools/dojo/_base/connect>Uncaught TypeError?: Cannot call method 'cancel' of undefined

1.

define.dojo.disconnectdojo/_base/connect:170 <chrome-devtools://devtools/dojo/_base/connect>

2.

dojo.declare.createPanelNamesTasksHeaderdojox/gantt/GanttChart:590 <chrome-devtools://devtools/dojox/gantt/GanttChart>

3.

dojo.declare.initdojox/gantt/GanttChart:1068 <chrome-devtools://devtools/dojox/gantt/GanttChart>

4.

(anonymous function)test_Gantt.html:144 <http://localhost:8880/side-demo/dojotoolkit/dojox/gantt/tests/test_Gantt.html>

5.

req.ready.cbdojo.js:1286 <http://localhost:8880/side-demo/dojotoolkit/dojo/dojo.js>

6.

onLoaddojo.js:1263 <http://localhost:8880/side-demo/dojotoolkit/dojo/dojo.js>

7.

detectPageLoadeddojo.js:1209 <http://localhost:8880/side-demo/dojotoolkit/dojo/dojo.js>

Uncaught TypeError?: Cannot call method 'cancel' of undefined in dojo/_base/connect (line. 170)

Attachments (1)

gantt_chart.patch (4.7 KB) - added by JayZ(zhouxiang) 9 years ago.

Download all attachments as: .zip

Change History (6)

Changed 9 years ago by JayZ(zhouxiang)

Attachment: gantt_chart.patch added

comment:1 Changed 9 years ago by JayZ(zhouxiang)

fixed! it is the dojo.disconnect issue, please refer to the attachment: "gantt_chart.patch"

comment:2 Changed 9 years ago by JayZ(zhouxiang)

the key issue is dojo.disconnect and dojo.destroy do not handle the "undefined" input parameter, I think it should be handled in these two dojo core methods, is it?

comment:3 Changed 9 years ago by Adam Peller

Resolution: fixed
Status: newclosed

(In [24546]) don't call dojo.destroy with a null pointer. Fixes #12803

comment:4 Changed 9 years ago by Adam Peller

Description: modified (diff)

see also [24545] Allow undefined argument for backwards compatibility, but don't document it (yet)

comment:5 Changed 9 years ago by bill

Milestone: tbd1.7
Note: See TracTickets for help on using tickets.