Opened 9 years ago

Closed 9 years ago

#12801 closed task (fixed)

All mobile CSS class names should have a unique prefix

Reported by: ykami Owned by: ykami
Priority: high Milestone: 1.7
Component: DojoX Mobile Version: 1.6.0
Keywords: 1.7-mobile Cc:
Blocked By: Blocking:

Description

(from Doug) All mobile CSS class names should have a prefix to try and reduce the chance of collisions with user defined CSS. Currently in themes/common/transitions, there are class names like "cover", "in", "out" that are sure to have collisions. I would suggest adding at least "mbl" to them: e.g. mblCover

Change History (2)

comment:1 Changed 9 years ago by ykami

I do not change the external spec. That is, the user specifies transition="slide" as before, but it is internally converted to prefixed class name "mblSlide". The theme css files will be changed, but test cases remain the same.

comment:2 Changed 9 years ago by ykami

Resolution: fixed
Status: newclosed

(In [24531]) Fixes #12801 !strict. Added a prefix "mbl" to all the css classes.

Note: See TracTickets for help on using tickets.