Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#12790 closed defect (fixed)

missing "unload" dependency

Reported by: bpburns Owned by: Rawld Gill
Priority: high Milestone: 1.7
Component: Core Version: 1.6.0
Keywords: Cc: Adam Peller
Blocked By: Blocking:

Description

When trying to use requirejs to load dojox.mobile there is an error where addOnWindowUnload is undefined. I worked around this by adding unload module as a dependency in dojo/main.js.

Change History (8)

comment:1 Changed 8 years ago by Adam Peller

Owner: set to Rawld Gill
Summary: _base/_loader/hostenv_browser.js and AMDmissing "unload" dependency

It seems that unload ought to be a dependency on dojo/_base/html, at least

comment:2 Changed 8 years ago by Rawld Gill

Status: newassigned

comment:3 Changed 8 years ago by Rawld Gill

Resolution: fixed
Status: assignedclosed

(In [25155]) removed unnecessary dependency; refs #12672; fixes #12790; !strict

comment:4 in reply to:  1 ; Changed 8 years ago by Rawld Gill

Replying to peller:

It seems that unload ought to be a dependency on dojo/_base/html, at least

I don't see why html ought to have unload as a dependency. What am I missing?

comment:5 in reply to:  4 Changed 8 years ago by Adam Peller

Replying to rcgill:

I don't see why html ought to have unload as a dependency. What am I missing?

At the time, there was a call to dojo.addOnWindowUnload. That seems to be gone now.

comment:6 Changed 8 years ago by bill

For better or worse it was removed in [24471].

comment:7 Changed 8 years ago by bill

PS: I filed #13065 about that.

comment:8 Changed 8 years ago by bill

(In [25195]) Put back unload require, it's needed again. Refs #13065, #13072, #12672, #12790 !strict.

Note: See TracTickets for help on using tickets.