Opened 8 years ago

Closed 8 years ago

#12788 closed defect (fixed)

dojo/_base/url.js needs require as a dependency in amd definition

Reported by: bpburns Owned by: Rawld Gill
Priority: high Milestone: 1.7
Component: Core Version: 1.6.0
Keywords: Cc: Adam Peller
Blocked By: Blocking:

Description

There is a call to require.nameToUrl that fails because require is not named as a dependency. This only shows up when using a third party amd loader such as requirejs.

Change History (4)

comment:1 Changed 8 years ago by bill

Owner: set to Rawld Gill

comment:2 Changed 8 years ago by Rawld Gill

Priority: normal → high
Status: new → assigned

comment:3 Changed 8 years ago by Rawld Gill

Need to understand if RequireJS is going to support public nameToUrl and/or toUrl. If so, code is OK as is; otherwise, we'll add the plugin for foreign loaders: 

//dojo/nameToUrl!
define([], {
  load:function(id, require, loaded){
    loaded(require.toUrl(id));
  }
});

comment:4 Changed 8 years ago by Rawld Gill

Resolution: → fixed
Status: assigned → closed

(In [25152]) fixes #13058; fixes #12788; !strict

Note: See TracTickets for help on using tickets.