Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#12783 closed enhancement (fixed)


Reported by: bill Owned by: bill
Priority: high Milestone: 1.7
Component: Dijit Version: 1.6.0
Keywords: Cc:
Blocked By: Blocking:


Make lightweight top level dijit/popup module based on dijit/_base/popup.

Change History (4)

comment:1 Changed 11 years ago by bill

Resolution: fixed
Status: newclosed

(In [24482]) Make lightweight dijit/popup module, and dijit/BackgroundIframe module, based on dijit/_base/popup. dijit/_base/popup leverages code in dijit/popup and dijit/BackgroundIframe, but retains old API for backwards compatibility.

Main API change from dijit/_base/popup to dijit/popup is that positions (of popup node relative to around node) are specified as array of strings like ["above", "below", ...] rather than tuple pairs like {"BL": "TL", ...}. As a side effect of this change, and #12418, submenus are now vertically centered relative to their parent MenuItem?, rather than being top-aligned. We could add a new alignment option (after-top-aligned?) if necessary to go back to the old behavior..

Fixes #12783 !strict.

comment:2 Changed 11 years ago by bill

(In [24491]) Convert _HasDropDown to use new dijit/popup module, refs #12783 !strict.

comment:3 Changed 11 years ago by bill

(In [25399]) Make dijit/popup module define dijit.popup "global". dijit/_base/popup merely decorates the methods in dijit.popup to support the deprecated API (in addition to the new API).

Refs #12783 !strict.

comment:4 Changed 11 years ago by bill

In [27061]:

Add tests for new dijit/popup module. Will keep dijit/tests/_base/popup.html around until 2.0, for testing the old API. Refs #12783.

Note: See TracTickets for help on using tickets.