Opened 9 years ago

Closed 9 years ago

#12762 closed defect (fixed)

TabContainer: checked tab loses checked CSS classes

Reported by: Shane O'Sullivan Owned by: Karl Tiedt
Priority: high Milestone: 1.7
Component: Dijit - LnF Version: 1.6.0
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

When a tab is checked, and is then clicked, it loses the dijitTabChecked and dijitChecked classes. This causes it to not be highlighted and can cause the tabs to become misaligned, leaving a number of empty pixels below them.

To replicate, load the themeTester with the Claro theme in Chrome, click the first tab a couple of times, and the tabs will move up and down, with the first tab alternating between appearing selected and unselected.

This is an ugly regression which would badly degrade the TabContainer look and feel

Change History (5)

comment:1 Changed 9 years ago by bill

Description: modified (diff)
Owner: set to bill
Status: newassigned
Summary: TabContainer checked tab loses checked CSS classes[regression] TabContainer: checked tab loses checked CSS classes

Ah, good catch, I'll fix.

comment:2 Changed 9 years ago by bill

Milestone: 1.6.11.7
severity: majornormal
Summary: [regression] TabContainer: checked tab loses checked CSS classesTabContainer: checked tab loses checked CSS classes

Oh, this is just happening on trunk, not in the 1.6.0 release or the 1.6/ branch.

comment:3 Changed 9 years ago by bill

Owner: changed from bill to Karl Tiedt
Status: assignednew

From [24421], I reopened #5601.

comment:4 Changed 9 years ago by Karl Tiedt

Interesting, I looked for anything like this as to why the last time it was regressed back to not working and there were no related tickets :/ is it fixable w/o losing the disabling ability?

comment:5 Changed 9 years ago by bill

Resolution: fixed
Status: newclosed

(In [24659]) Revert [24421], refs #5601, fixes #12762.

Note: See TracTickets for help on using tickets.