Changes between Initial Version and Version 3 of Ticket #12761


Ignore:
Timestamp:
Apr 24, 2011, 9:49:11 PM (11 years ago)
Author:
bill
Comment:

Surely we won't change ItemFileReadStore as it's essentially deprecated in favor of ​dojo.store.Memory. The good news is that that dojo.store.Memory doesn't add any attributes to the original objects. Confirmed by running util/doh/runner.html?testModule=dojo.tests.store.Memory and setting a breakpoint around the first store.get() call.

I'm going to mark this as fixed in 1.6, through the new dojo.store.Memory API.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #12761

    • Property Status changed from new to closed
    • Property Resolution changed from to fixed
    • Property Summary changed from ItemFileReadStore is not read-only to ItemFileReadStore: don't modify original data objects
    • Property Priority changed from high to normal
    • Property Milestone changed from tbd to 1.6
    • Property Type changed from defect to enhancement

  • Ticket #12761 – Description

    initial v3  
    1313I think that the whole scenario is actually quite rude, to apply such bad practice and then add a disclaimer to the docs like, deal with it, we told you so.
    1414
    15 So this issue is about changing the ItemFileReadStore in such a way that it does not mess around with the model objects. If it really needs its own data to play with then it should create it.
     15So this issue is about changing the !ItemFileReadStore in such a way that it does not mess around with the model objects. If it really needs its own data to play with then it should create it.