ItemFileReadStore: don't modify original data objects

[bht]

​http://docs.dojocampus.org/dojo/data/ItemFileReadStore

For data, the documentation contains a disclaimer:

"The data object passed in is directly used and modified. If you want to reuse a data object, make sure you copy it before you pass it in."

However, with the effort required to use the implementation, one expects to deal with a MVC architecture that leaves the business objects alone, as other frameworks do.

With that I mean that the implementation expects a Model, with implementation specific requirements, which contains in it the Model Object.

It appears that dojo converts attributes of the model objects into arrays containing the attributes at index 0.

I think that the whole scenario is actually quite rude, to apply such bad practice and then add a disclaimer to the docs like, deal with it, we told you so.

So this issue is about changing the ItemFileReadStore in such a way that it does not mess around with the model objects. If it really needs its own data to play with then it should create it.

[Jared Jurkiewicz]

The store clearly states its expectations and what behaviors it has. It isn't a disclaimer, it's a clear statement on what it does. Therefore this cannot be classified as a bug and has been adjusted to enhancement state to alter current behavior.

[bill]

Surely we won't change ItemFileReadStore as it's essentially deprecated in favor of ​dojo.store.Memory. The good news is that that dojo.store.Memory doesn't add any attributes to the original objects. Confirmed by running util/doh/runner.html?testModule=dojo.tests.store.Memory and setting a breakpoint around the first store.get() call.

I'm going to mark this as fixed in 1.6, through the new dojo.store.Memory API.