Opened 8 years ago

Closed 5 years ago

Last modified 5 years ago

#12752 closed enhancement (fixed)

Provide a link to the Demos (online)

Reported by: lazaridis_com Owned by: dylan
Priority: low Milestone: 1.10
Component: Website Version:
Keywords: Cc: cjolif
Blocked By: Blocking:

Description

Today I came back to the website, looking for the online demos that I saw on the first day.

But after a few minutes (starting from the homepage of the dojotoolkit.org), I was not able to find the demos.

Suggestion would be to have the "Demos" link visible within a 2nd level menu (or even in the 1st level).

Change History (23)

comment:1 Changed 8 years ago by Dustin Machi

Owner: changed from Dustin Machi to itorrey

comment:2 Changed 8 years ago by ben hockey

Keywords: needsreview added
Priority: highlow

when you click on the 2nd level menu at http://dojotoolkit.org/features/ you can find a "See it Action" link on each section. this links you to various parts of http://demos.dojotoolkit.org/demos/

can this ticket be closed?

comment:3 Changed 8 years ago by lazaridis_com

a) Even with your description, I've still problems to find the demos.

b) "See it in Action" is not as descriptive as a simple "Demo" (for the button/link text).

You have such a nice demo section in the site, simply link to it, thus visitors spot it immediately:

http://demos.dojotoolkit.org/demos/

I would expect a direct link:

Home Features Demos Documentation Community Blog

comment:4 Changed 7 years ago by bill

Milestone: tbd
Owner: changed from itorrey to dylan
Status: newassigned

comment:5 Changed 7 years ago by dylan

I'd really like to see the following before we move the demos to top level:

  1. Make sure they work in all supported browsers
  2. For older demos, designate which versions of Dojo and which browsers they work with.

comment:6 Changed 7 years ago by dylan

Cc: cjolif added
Keywords: needsreview removed

Adding Christophe as a cc. Can we version the demos like we do the docs? And can we go through and prune things out from the demos for the 1.8 version that aren't 1.8 code?

comment:7 Changed 7 years ago by cjolif

We can certainly version the demos and I do think this is a good idea. Actually I added that point in Kitson's 1.9 document. That said I don't think I have access to the server to actually do this, this looks more like an infrastructure task. We basically just need to deploy n-times for n-versions on the server with different urls.

About pruning the demos code, I think it is done for most of the demos we handle. For example we have moved the gauges demos in 1.8 from old gauges to new gauges etc... That said I agree some other demos looks very old. Do we have a list of owners for each of the demos?

comment:8 Changed 7 years ago by dylan

Milestone: tbd1.9

I can discuss the infrastructure side of this with Robert, it should be pretty straightforward.

As far as the list of demo owners, I don't have a list, we would just need to look through the commit logs.

I would suggest that make a quick list of each demo, what its current status is (does it work, what version of Dojo APIs does it use), and then we can ask for help in updating them.

comment:9 Changed 6 years ago by Colin Snover

Milestone: 1.91.10

1.9 is released; moving remaining tickets to next milestone.

comment:10 Changed 6 years ago by dylan

Owner: changed from dylan to cjolif

@cjolif, can we prune back the demos page to only include those that are proper AMD? What does that look like?

I think it's time to make this more prominent, but I'm afraid that many of our demos are currently anti-patterns of best practices?

Assigning to you to get your attention, please assign back to me after you've updated it.

comment:11 Changed 6 years ago by cjolif

Demos page is built from https://github.com/dojo/demos/blob/master/demos.php. It is basically just sniffing the directory and listing all the demos in demos directory taking some metadata in their READMEs (like the category).

So removing some demos (non AMD ones I guess here) would mean deleting them from github repo or from the server where we deploy things.

We could also create a new mechanism in demos.php to ignore some stuff but more work would be involved obviously.

Note that some additional ("external") demos are listed from this file:

https://github.com/dojo/demos/blob/master/resources/ext_demos.json

Maybe pruning what is not AMD in this file and deleting the non AMD demos from the server is the easiest way to proceed and avoid deleting them from github?

comment:12 Changed 5 years ago by cjolif

Per meeting discussions, the metadata should list which demos are non AMD and put them lesser priority (i.e. lower down the page)

comment:13 Changed 5 years ago by Christophe Jolif <cjolif@…>

In af9cdba569baec19c393be41112ed5dbcf0b7d63/demos:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:14 Changed 5 years ago by cjolif

Owner: changed from cjolif to dylan

Actually (per category) the AMD demos were already vastly listed first. I just had 2 exceptions that I dealt with thanks to the existing priority metadata (no need to introduce another one).

comment:15 Changed 5 years ago by dylan

Owner: changed from dylan to cjolif

This change has been pushed live. We should switch the theme previewer to use the version in dijit/themes though?

comment:16 Changed 5 years ago by Christophe Jolif <cjolif@…>

In d3b992720e448aed1deaa6864889aa5dc64abb76/demos:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:17 Changed 5 years ago by cjolif

Owner: changed from cjolif to dylan

preview use latest version now.

comment:18 Changed 5 years ago by dylan

These will be rebuilt next week. Once verified, I'll update the web site with a more prominent link.

comment:19 Changed 5 years ago by Dylan Schiemann <dylan@…>

In 9082e230d8af18eb5087f659ea2466cfb3b595c6/demos:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:20 Changed 5 years ago by Dylan Schiemann <dylan@…>

In bce3dc84350ba31f04a7a3b9b23f2ac1a743da88/demos:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:21 Changed 5 years ago by dylan

Resolution: fixed
Status: assignedclosed

Demos button has been committed to the site, and will be live with the next site push (either today or Monday).

comment:22 Changed 5 years ago by dylans <dylan@…>

In c1953928e3c9d054a9c0a792c94784ce9e57f822/demos:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:23 Changed 5 years ago by dylans <dylan@…>

In 0cb3e534951fce599890376c7432795042ef0437/demos:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Note: See TracTickets for help on using tickets.