[patch][ccla] Forced default content type prevents FormData object in dojo/request

[ghiloni]

with the advent of the HTML5 Files API, the FormData? object can be used to post files to an endpoint using XMLHTTPRequest, and more specifically, dojo.xhr. The problem lies within the setup of the native XHR. In dojo.xhr(), the content type is always set. The FormData? object will set the content type on the XHR for you, including the appropriate boundary, which it creates when it serializes the object. The ioArgs.query object should be checked if it is a FormData? instance before setting the default content type (while still respecting the explicit contentType argument, if one is passed).

A suggested patch has been attached. This occurs on all fully HTML5-capable browsers (FF4, Chrome 9, Safari 5) that I've tested.

[rmurphey]

See also #12141

[Colin Snover]

Bulk update of open ticket priorities.

[bill]

Bulk change to reassign IO tickets to Bryan, since he is working on new dojo/request module. Some of these tickets should probably be closed as already fixed, invalid, or wontfix.

[Adam Peller]

Some issues with the patch: FormData? would likely trigger a ReferenceError? on older browsers. Also, there's no else clause, so all codepaths are not necessarily covered, are they?

[cjolif]

Replying to peller:

Some issues with the patch: FormData? would likely trigger a ReferenceError? on older browsers. Also, there's no else clause, so all codepaths are not necessarily covered, are they?

I think the else clause is the case they want to cover, i.e. if there is no explicit contentType and that there is a FormData in the query then they don't want a default content type to be set because it will be automatically done.

[cjolif]

fixing the issue for 1.7 (working on IE + formatting fix)

[cjolif]

fixes for 1.8 where the problem with FormData? is slightly different. It happens Content-Type is not set to a default value in 1.8 however ioArgs.data is pass to objectToQuery which we don't want for FormData? that needs to stay as-is.

[Colin Snover]

1.8 is frozen. Move all enhancements to next release. If you need an exemption from the freeze for this ticket, contact me immediately.

[Bryan Forbes]

In [28927]:

Make sure FormData? objects are skipped for data processing. Added unit test. refs #12750 !strict

[Bryan Forbes]

The provided patch for 1.7 removes the way to remove the "Content-Type" header that has been in Dojo since 1.0 and would break the API. In 1.7, the following should work without the provided patch:

dojo.xhrPost({
    url: "/some/url",
    headers: { "Content-Type": false },
    postData: FormData(dojo.byId("someNode"))
}).then(function(){
});

The patch for 1.8 is somewhat correct, however there should be a has test for native FormData support and the instanceof check should be passed into util.parseArgs() as the third parameter. I checked in a fix and unit test for this. Please include unit tests in the future.