[patch] [ccla] ScrollingTabController doesn't properly select child before started

[Brian Arnold]

We've observed that when a tab container was created (either declaratively or programmatically) that if a tab was selected that would be outside of initial scroll position, that it wouldn't show the tab properly. Later tab selections would cause the scroll properly, but it wasn't happening prior to startup.

Looking through the code, it appears that the ScrollingTabController?'s _selectedTab properly was only being set if _postResize were true. Adjusting it to properly set _selectedTab and then only execute the smooth scroll if _postResize is true.

I've attached a small patch that was written against r24446 of dijit's trunk, as well as a couple of example files that work against 1.6.0 on Google CDN, and have tested this code against Chrome 10, Firefox 4, and IE8. This work falls under SitePen?'s CCLA.

[Brian Arnold]

Patch to ScrollingTabController? to properly set selected tab

[Brian Arnold]

Example of a selected tab not showing properly

[Brian Arnold]

Example of applying this patch to ScrollingTabController?'s prototype (using safeMixin so that this.inherited works)

[Tom Trenka]

[ccla] designation is from SitePen?, Inc.

[bill]

Thanks for the patch and test file. Unfortunately the patch causes a failure in the dijit/test/layout/TabContainer.html test file (before adding a new test for this ticket).

[bill]

Hmm, actually nevermind, it's not happening for me anymore, I guess it's an intermittent failure. I'll check in your fix, thanks.

[bill]

(In [24448]) Fix initial scroll position of ScrollableTabController, thanks to brianarn for patch, fixes #12748 !strict.