Opened 9 years ago

Closed 8 years ago

#12689 closed enhancement (fixed)

3 states ToggleSplitter

Reported by: Gu Yi, He Owned by: Sam Foster
Priority: high Milestone: 1.7
Component: DojoX Layout Version: 1.6.0
Keywords: toggle bordercontainer splitter layout Cc: drschwar@…, heguyi@…, zhongsq@…
Blocked By: Blocking:

Description (last modified by Adam Peller)

This is an enhancement of ToggleSplitter. Implements three states on the splitter: open, collapsed (optional) and closed. The user clicks on the toggle node to switch instead of double clicking on the splitter.

Attachments (2)

ToggleSplitter.patch (30.2 KB) - added by Adam Peller 8 years ago.
3-state splitter patch from Eldon (IBM, CCLA)
ToggleSplitter.zip (6.1 KB) - added by Adam Peller 8 years ago.
associated images from Eldon (IBM, CCLA)

Download all attachments as: .zip

Change History (11)

comment:1 Changed 9 years ago by Gu Yi, He

Wondering if this implementation could replace the original one. Please have a look. Thanks.

comment:2 Changed 9 years ago by Sam Foster

What should I be looking at?

How does the ToggleBorderContainer? add value over the use of dojox.layout.ToggleSplitter? with dijit.layout.BorderContainer??

comment:3 Changed 9 years ago by Gu Yi, He

Sorry. Patch is coming soon. This one proposed a ToggleSplitter? with new behavior and look&feel.

comment:4 Changed 8 years ago by Adam Peller

Owner: set to Sam Foster

Hi Sam. Sorry this is last minute. Could you take a look at this patch from Eldon and see if we can get it in by this weekend? He replaced the test page and implemented three states on the splitter: open, collapsed (optional) and closed. The user clicks on the toggle node to switch instead of double clicking on the splitter. Are you ok with this enhancement, or should it be a separate widget?

Changed 8 years ago by Adam Peller

Attachment: ToggleSplitter.patch added

3-state splitter patch from Eldon (IBM, CCLA)

Changed 8 years ago by Adam Peller

Attachment: ToggleSplitter.zip added

associated images from Eldon (IBM, CCLA)

comment:5 Changed 8 years ago by Adam Peller

Summary: ToggleBorderContainer3 states ToggleSplitter

comment:6 Changed 8 years ago by Adam Peller

Description: modified (diff)

comment:7 Changed 8 years ago by Sam Foster

I think the 3 states work much better, I'll commit this. I had some other pending changes around the openSize and some simplification, but I'll address that separately, possibly post1.7. The icons/splitterToggleH.png and icons/splitterToggleV.png images are MIA? I don't have them, though the CSS has called for them since ~1.4

comment:8 Changed 8 years ago by Adam Peller

Sam, check out the zip. I think the images you want are there. Thanks!

comment:9 Changed 8 years ago by Sam Foster

Resolution: fixed
Status: newclosed

Yep, scratch that about the images, the patch and images went into r24669

Note: See TracTickets for help on using tickets.