Opened 8 years ago

Closed 8 years ago

#12687 closed defect (duplicate)

StackContainer's layout implementation is wrong

Reported by: millennium Owned by:
Priority: high Milestone: tbd
Component: Dijit Version: 1.6.0
Keywords: dijit doLayout resize StackContainer TabContainer Cc:
Blocked By: Blocking:

Description

The StackContainer? promises to be an layoutContainer (isLayoutContainer == true). But in the situation where the StackContainers? (or TabContainer?) "doLayout" property is set to false it fails to keep this promise to the firstchild (or selected) at startup.

looking at the layout function: 

if(this.doLayout && this.selectedChildWidget && this.selectedChildWidget.resize){
  this.selectedChildWidget.resize(this._containerContentBox || this._contentBox);
}

Which doesn't call resize when "doLayout" is false. This should be: 

if(this.selectedChildWidget && this.selectedChildWidget.resize) {
  if (this.doLayout) {
    this.selectedChildWidget.resize(this._containerContentBox || this._contentBox);
  }else{
    this.selectedChildWidget.resize();
  }
}

Change History (2)

comment:1 Changed 8 years ago by millennium

[Patch][CLA]

comment:2 Changed 8 years ago by bill

Resolution: → duplicate
Status: new → closed

Thanks, dup of #11690.

Note: See TracTickets for help on using tickets.