Opened 10 years ago
Closed 8 years ago
#12686 closed enhancement (wontfix)
Message Box
Reported by: | Gu Yi, He | Owned by: | Adam Peller |
---|---|---|---|
Priority: | high | Milestone: | future |
Component: | DojoX Form | Version: | 1.6.0 |
Keywords: | message box form | Cc: | [email protected]…, [email protected]…, [email protected]… |
Blocked By: | Blocking: |
Description (last modified by )
MessageBox? is a container for messages in a designated area. A message in a MessageBox? could be an
error, a warning or some information.
A single message contains:
Message icon
Message text
Show Details or Hide Details toggle link
Message ID
Message explanation
Messages in MessageBox? are sorted by severity first and then by occurence time automatically.
Attachments (2)
Change History (18)
comment:1 Changed 10 years ago by
comment:2 Changed 10 years ago by
if a dup of #8805, how difficult to address issues of 8805 using this patch by 5pm 5/6/2011? Can't tell, since there is no patch here.
comment:3 Changed 10 years ago by
Owner: | changed from dante to Adam Peller |
---|
comment:4 Changed 10 years ago by
Description: | modified (diff) |
---|
comment:6 Changed 10 years ago by
It is accessible and I believe localized; will confirm that latter.
comment:7 Changed 10 years ago by
unrelated to #8805. a11y and i18n are helpful, but not a requirement for DojoX. There is a11y and i18n code present in the patch. I will review by the end of the week.
comment:8 Changed 10 years ago by
comment:9 follow-up: 10 Changed 10 years ago by
the dojox.messaging namespace used seems too broad. maybe dojox.widgets.MessageBox? instead, since that would be consistent dumping ground for other misc widgets like this? In the future, dojox.widgets needs to be split out into separate projects/packages, but we're not there yet.
comment:10 Changed 10 years ago by
Replying to chrism:
the dojox.messaging namespace used seems too broad. maybe dojox.widgets.MessageBox? instead, since that would be consistent dumping ground for other misc widgets like this? In the future, dojox.widgets needs to be split out into separate projects/packages, but we're not there yet.
Hi chris, currently we put it in dojox.messaging rather than dojox.widgets because we'd like to contribute some other new 'message widgets' such as MessageDialog? in the future. I think it's ok to move it to dojox.widgets. :-)
comment:11 Changed 10 years ago by
New subprojects require careful consideration with a proposal to the dojox project leads, in addition to the normal code contribution. "Messaging" sounds a lot like a networking protocol, which could be confusing. I agree that it's best left in dojox.widget, for now (admittedly, a project without a very clear purpose... more of a catch-all for widgets) I'm hoping this all gets fixed soon when we reorganize dojox.
comment:12 Changed 10 years ago by
I had the same concerns about the package. Besides MessageBox/MessageDialog, do you have other related widgets that you plan to contribute? [For example] is this part of a larger project for widgets needed to build an IDE?
comment:13 Changed 10 years ago by
We'll be working on enhancements to dojox.widget.Toaster which would probably make sense to have in this package. Thoughts?
comment:14 Changed 10 years ago by
right now, pretty much everything dijit._Widget-based is in dojox/widget, with the exceptions being form- and layout-based widgets, which sort of mirrors the dijit architecture. So far, widgets have not been classified by use. Rather than starting to do that now piecemeal, I think it might be better to do in the next re-org, whenever that happens.
comment:15 Changed 9 years ago by
Cc: | [email protected],[email protected],[email protected] → [email protected], [email protected], [email protected] |
---|---|
Milestone: | 1.7 → future |
comment:16 Changed 8 years ago by
Resolution: | → wontfix |
---|---|
Status: | new → closed |
We are no longer accepting additions to DojoX. If there is a desire for this, it should be setup as a community package and made available on http://packages.dojofoundation.org/.
Is this a dup of 8805?