Opened 9 years ago

Closed 7 years ago

#12686 closed enhancement (wontfix)

Message Box

Reported by: Gu Yi, He Owned by: Adam Peller
Priority: high Milestone: future
Component: DojoX Form Version: 1.6.0
Keywords: message box form Cc: drschwar@…, heguyi@…, zhongsq@…
Blocked By: Blocking:

Description (last modified by Chris Mitchell)

MessageBox? is a container for messages in a designated area. A message in a MessageBox? could be an
error, a warning or some information.
A single message contains:

Message icon
Message text
Show Details or Hide Details toggle link
Message ID
Message explanation

Messages in MessageBox? are sorted by severity first and then by occurence time automatically.

Attachments (2)

MessageBoxImages.zip (6.4 KB) - added by Adam Peller 9 years ago.
from Siqi Zhong (IBM, CCLA)
MessageBox.patch (33.9 KB) - added by Adam Peller 9 years ago.
from Siqi Zhong (IBM, CCLA)

Download all attachments as: .zip

Change History (18)

comment:1 Changed 9 years ago by Chris Mitchell

Is this a dup of 8805?

comment:2 Changed 9 years ago by Chris Mitchell

if a dup of #8805, how difficult to address issues of 8805 using this patch by 5pm 5/6/2011? Can't tell, since there is no patch here.

comment:3 Changed 9 years ago by Chris Mitchell

Owner: changed from dante to Adam Peller

comment:4 Changed 9 years ago by Chris Mitchell

Description: modified (diff)

comment:5 Changed 9 years ago by Chris Mitchell

is this localized and accessible?

comment:6 Changed 9 years ago by David Schwartz

It is accessible and I believe localized; will confirm that latter.

comment:7 Changed 9 years ago by Adam Peller

unrelated to #8805. a11y and i18n are helpful, but not a requirement for DojoX. There is a11y and i18n code present in the patch. I will review by the end of the week.

Changed 9 years ago by Adam Peller

Attachment: MessageBoxImages.zip added

from Siqi Zhong (IBM, CCLA)

comment:8 in reply to:  5 Changed 9 years ago by siqi

Replying to chrism:

is this localized and accessible?

Yes, it is localized and accessible.

comment:9 Changed 9 years ago by Chris Mitchell

the dojox.messaging namespace used seems too broad. maybe dojox.widgets.MessageBox? instead, since that would be consistent dumping ground for other misc widgets like this? In the future, dojox.widgets needs to be split out into separate projects/packages, but we're not there yet.

comment:10 in reply to:  9 Changed 9 years ago by siqi

Replying to chrism:

the dojox.messaging namespace used seems too broad. maybe dojox.widgets.MessageBox? instead, since that would be consistent dumping ground for other misc widgets like this? In the future, dojox.widgets needs to be split out into separate projects/packages, but we're not there yet.

Hi chris, currently we put it in dojox.messaging rather than dojox.widgets because we'd like to contribute some other new 'message widgets' such as MessageDialog? in the future. I think it's ok to move it to dojox.widgets. :-)

comment:11 Changed 9 years ago by Adam Peller

New subprojects require careful consideration with a proposal to the dojox project leads, in addition to the normal code contribution. "Messaging" sounds a lot like a networking protocol, which could be confusing. I agree that it's best left in dojox.widget, for now (admittedly, a project without a very clear purpose... more of a catch-all for widgets) I'm hoping this all gets fixed soon when we reorganize dojox.

comment:12 Changed 9 years ago by bill

I had the same concerns about the package. Besides MessageBox/MessageDialog, do you have other related widgets that you plan to contribute? [For example] is this part of a larger project for widgets needed to build an IDE?

comment:13 Changed 9 years ago by David Schwartz

We'll be working on enhancements to dojox.widget.Toaster which would probably make sense to have in this package. Thoughts?

comment:14 Changed 9 years ago by Adam Peller

right now, pretty much everything dijit._Widget-based is in dojox/widget, with the exceptions being form- and layout-based widgets, which sort of mirrors the dijit architecture. So far, widgets have not been classified by use. Rather than starting to do that now piecemeal, I think it might be better to do in the next re-org, whenever that happens.

Changed 9 years ago by Adam Peller

Attachment: MessageBox.patch added

from Siqi Zhong (IBM, CCLA)

comment:15 Changed 8 years ago by Adam Peller

Cc: drschwar@us.ibm.com,heguyi@cn.ibm.com,zhongsq@cn.ibm.comdrschwar@us.ibm.com, heguyi@cn.ibm.com, zhongsq@cn.ibm.com
Milestone: 1.7future

comment:16 Changed 7 years ago by Kitson Kelly

Resolution: wontfix
Status: newclosed

We are no longer accepting additions to DojoX. If there is a desire for this, it should be setup as a community package and made available on http://packages.dojofoundation.org/.

Note: See TracTickets for help on using tickets.