Opened 10 years ago
Closed 5 years ago
#12679 closed defect (patchwelcome)
Webkit sends keycode 10 for Enter when ctrl is held at same time
Reported by: | druspini | Owned by: | Kris Zyp |
---|---|---|---|
Priority: | high | Milestone: | 1.13 |
Component: | Events | Version: | 1.6.0 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
When listening for the keyboard event "Ctrl+Enter", typically you might check
if (evt.ctrlKey && evt.keyCode == dojo.keys.ENTER) { ''....do something...'' }
However, Webkit will pass the keyCode '10' rather than '13'. 13 is the value of dojo.keys.ENTER and therefore the test will fail.
As this is inconsistent for Webkit and can easily cause problems for developers, it would be great for Dojo to handle it correctly.
Change History (2)
comment:1 Changed 10 years ago by
Owner: | set to Kris Zyp |
---|
comment:2 Changed 5 years ago by
Milestone: | tbd → 1.12 |
---|---|
Resolution: | → patchwelcome |
Status: | new → closed |
Given that no one has shown interest in creating a patch in the past 4+ years, I'm closing this as patchwelcome.
Note: See
TracTickets for help on using
tickets.
Note that there's a TODO in dojo/tests/_base/eventKeyPressRobot.html to test this, please add a test for it.