Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#12678 closed enhancement (fixed)

enhance doh to leverage AMD

Reported by: Rawld Gill Owned by: Rawld Gill
Priority: high Milestone: 1.7
Component: TestFramework Version: 1.6.0
Keywords: Cc: Sam Foster
Blocked By: Blocking:

Description

As part of #12672, DOH was upgraded to clean cruft and leverage dojo's AMD loader. This is a blanket ticket that covers just DOH issues until 12672 settles.

Change History (11)

comment:1 Changed 9 years ago by Rawld Gill

Cc: Sam Foster added
Status: newassigned

#12672 broke util/doh/runner.sh; reported by sfoster on 12672

comment:2 Changed 9 years ago by Rawld Gill

Resolution: fixed
Status: assignedclosed

(In [24335]) fixed broken runner.sh; fixes #12678

comment:3 Changed 9 years ago by bill

Component: GeneralTestFramework

comment:4 Changed 9 years ago by bill

Resolution: fixed
Status: closedreopened

Starting in [24328], DOH is failing on IE8 (and probably other IE versions) when doh.error() because console.error.apply() is not a valid call. (It's something to do with console being weird on IE)

It causes a breakpoint in the debugger or a popup dialog about "object is not a valid call". You may not see the popup dialog depending on your IE settings.

comment:5 Changed 9 years ago by Rawld Gill

(In [24417]) enhanced doh to allow running with sandboxed dojo; refs #12678

comment:6 Changed 9 years ago by Rawld Gill

(In [24469]) fixed race condition in doh; refs #12678

comment:7 Changed 9 years ago by Rawld Gill

(In [24749]) added feature to pass config to test pages via doh; improved signature resolution algorithm of doh.register; refs #12678; !strict

comment:8 Changed 9 years ago by Rawld Gill

(In [24754]) fixed package.json to be valid JSON; refs #12672; refs #12678

comment:9 Changed 9 years ago by Rawld Gill

Resolution: fixed
Status: reopenedclosed

Closing this ticket; DOH appears stable with AMD changes. If you find issues please open a new ticket.

comment:10 Changed 8 years ago by ben hockey

In [26804]:

get doh/tests/scopeTest and doh/tests/selfTest working.
refs #13956, #13957, #12672, #12740, #12678 !strict

comment:209 Changed 8 years ago by Adam Peller

In [28549]:

Make DOH work again. Thanks, haysmark. Refs #12678

Note: See TracTickets for help on using tickets.