Opened 10 years ago
Closed 10 years ago
#12649 closed defect (fixed)
EDG - nested sorting info is not following after column moved
Reported by: | evan | Owned by: | evan |
---|---|---|---|
Priority: | high | Milestone: | 1.7 |
Component: | DojoX Grid | Version: | 1.6.0 |
Keywords: | edg, nestedsorting, column, dnd, moving | Cc: | |
Blocked By: | Blocking: |
Description
Sorting info and focus are not following after column(s) moved
Attachments (1)
Change History (4)
comment:1 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
Changed 10 years ago by
Attachment: | nested_sort.patch added |
---|
Patch to fixed NestedSorting? column reordering code
comment:2 Changed 10 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
This patch does not handle the case where the column that is reordered is not a nestedSort column. For instance, if a grid is sorted by column 2, and column 3 is dragged over to column 2 (thus pushing column 2 to the 3 spot), the grid still indicates that column 2 is the sorted column.
This is because its logic only checks to see whether the moved columns are sorted columns. It does not account for the fact that a column can be indirectly repositioned, in an absolute sense, when a column to its left is moved to its right, and vice versa.
I have patched the code to solve this problem. Attached is a diff of /dojox/grid/enhanced/plugins/NestedSorting.js.
comment:3 Changed 10 years ago by
Milestone: | 1.6.1 → 1.7 |
---|---|
Resolution: | → fixed |
Status: | reopened → closed |
Thanks ajshankar!
Actually it's caused by an issue in DnD - the column mapping is incorrect in some occasions e.g. target pos < source column index, it's fixed with [25506], with that, nested sorting is now working well with column moving.
(In [24285]) Fixes #12649, !strict, making sure sorting info and focus follows after column(s) moved, patch from Nate(IBM, CCLA), applied both to trunk and 1.6 branch