Opened 8 years ago

Closed 8 years ago

#12642 closed enhancement (fixed)

[patch][ccla][reqs #12405] Add bidi text support to dojox.charting

Reported by: cjolif Owned by: Chris Mitchell
Priority: high Milestone: 1.7
Component: Charting Version: 1.6.0
Keywords: 1.7-mobile Cc:
Blocked By: Blocking:

Description

Thanks to Maria Vinikov (IBM, CCLA) and Tomer Mahlin (IBM, CCLA).

This patch adds bidi text capabilities to dojox.charting.

It is based on #12326 and #12405.

It adds two classes one for dojox.charting based module and one for dojox.charting.widget (to not force dijit for charting users that don't need it).

Attachments (11)

Change History (19)

comment:1 Changed 8 years ago by tomerm

I attached the design document providing details on the suggested code changes. Apologies for splitting it up into 8 separate files (the limit for single attachment is ~250 K only).

comment:2 Changed 8 years ago by Chris Mitchell

Milestone: tbd1.7
Owner: changed from Eugene Lazutkin to cjolif
Priority: normalhigh

comment:3 Changed 8 years ago by Chris Mitchell

Christophe will refactor this patch for AMD this weekend...it accompanies the already integrated patch for gfx BIDI, and should have been handled at that time. Patch design uses same opt-in/monkeypatch approach used in gfx BIDI enablement.

comment:4 Changed 8 years ago by Chris Mitchell

Keywords: 1.7-mobile added

Changed 8 years ago by cjolif

new version of the patch including refactoring for AMD, to be applied after http://bugs.dojotoolkit.org/attachment/ticket/12844/dojox.charting.patch

comment:5 Changed 8 years ago by cjolif

Note that dojox.string(.BidiEngine?) has not itself been ported to AMD. The AMD code of this patch could be improved once it will be done.

comment:6 Changed 8 years ago by Chris Mitchell

Summary: [patch][ccla] Add bidi text support to dojox.charting[patch][ccla][reqs #12405] Add bidi text support to dojox.charting

comment:7 Changed 8 years ago by Chris Mitchell

Owner: changed from cjolif to Chris Mitchell

Changed 8 years ago by cjolif

with better patch format

comment:8 Changed 8 years ago by Chris Mitchell

Resolution: fixed
Status: newclosed

(In [24810]) fixes #12642 bidi support !strict

Note: See TracTickets for help on using tickets.