Opened 8 years ago

Closed 8 years ago

#12631 closed defect (fixed)

LinkDialog: modifies read only dijit common messages, can't create Dialogs afterwards

Reported by: bill Owned by: bill
Priority: high Milestone: 1.7
Component: Editor Version: 1.6.0
Keywords: Cc:
Blocked By: Blocking:

Description

When the LinkDialog plugin is loaded, it inadvertently modifies the dijit common messages:

var messages = dojo.mixin(dojo.i18n.getLocalization("dijit", "common", this.lang),
	dojo.i18n.getLocalization("dijit._editor", "LinkDialog", this.lang));

This causes problems if a Dialog is later (attempted to be) created, when this code runs:

postMixInProperties: function(){
	var _nlsResources = dojo.i18n.getLocalization("dijit", "common");
	dojo.mixin(this, _nlsResources);
	this.inherited(arguments);
},

It overwrites the Dialog.set() method with a string ("Set" in english).

This error appears readily with the AMD build so I won't bother checking in a separate test case.

Change History (1)

comment:1 Changed 8 years ago by bill

Resolution: fixed
Status: newclosed
Summary: LinkDialog: modifies read only dijit common messages, causing AMD problemsLinkDialog: modifies read only dijit common messages, can't create Dialogs afterwards

Fixed in [24247].

Note: See TracTickets for help on using tickets.