Opened 10 years ago

Last modified 6 years ago

#12630 closed defect

[regression] dojox.Layout.FloatingPane is moved / resized on browser window resize when it shouldn't be — at Version 2

Reported by: David M Owned by:
Priority: high Milestone: 1.5.4
Component: DojoX Layout Version: 1.6.0
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

Regression from 1.5. If you open the nightly floating pane tests: http://archive.dojotoolkit.org/nightly/checkout/dojox/layout/tests/test_FloatingPane.html

and compare it to an older version: http://archive.dojotoolkit.org/dojo-2010-05-01/checkout/dojox/layout/tests/test_FloatingPane.html

Steps to reproduce:

  1. grab any floating pane
  2. move it 2.a. dock it
  3. resize the browser window 3.a undock it

Observed Behavior: Floating panes seem to move / dock to top left corner, in some situations they are resized to width/height 0/0px (sometimes the dim passed to 'resize' is undefined). They do not move back to where they were before being docked, etc.

Expected Behavior: (see older unit test page) They should stay where they were / not be resized, (in my app I observed both moving to the left, and sometimes being resized to 0/0). The behavior in the previous version seems more desirable.

Please let me know if I can be of any help on this. Thanks!

Change History (3)

Changed 10 years ago by David M

Attachment: floatingPane_12630.patch added

patch for 12630 -- appears to be a typo

comment:1 Changed 10 years ago by David M

upon further investigation, it seems like there was a very old copy-paste bug in this control? line 259 had resize setting: this._currentState = dim;

instead of: this._naturalState = dim;

I searched through the entire code base, and I don't see '_currentState' used anywhere, so I'm assuming it was changed some time ago. Does this look like a good patch?

comment:2 Changed 10 years ago by bill

Component: DijitDojoX Layout
Description: modified (diff)
Summary: regression from 1.5 - dojox.Layout.FloatingPane is moved / resized on browser window resize when it shouldn't be[regression] dojox.Layout.FloatingPane is moved / resized on browser window resize when it shouldn't be

Trivial patch so no CLA needed but if you want to file bigger patches please file http://dojofoundation.org/about/cla, thanks! Forwarding bug to Pete, this is dojox.layout not dijit.

Note: See TracTickets for help on using tickets.