[regression] dojox.Layout.FloatingPane is moved / resized on browser window resize when it shouldn't be

[David M]

Regression from 1.5. If you open the nightly floating pane tests: ​http://archive.dojotoolkit.org/nightly/checkout/dojox/layout/tests/test_FloatingPane.html

and compare it to an older version: ​http://archive.dojotoolkit.org/dojo-2010-05-01/checkout/dojox/layout/tests/test_FloatingPane.html

Steps to reproduce:

1. grab any floating pane
2. move it
3. dock it
4. resize the browser window
5. undock it

Observed Behavior: Floating panes seem to move / dock to top left corner, in some situations they are resized to width/height 0/0px (sometimes the dim passed to 'resize' is undefined). They do not move back to where they were before being docked, etc.

Expected Behavior: (see older unit test page) They should stay where they were / not be resized, (in my app I observed both moving to the left, and sometimes being resized to 0/0). The behavior in the previous version seems more desirable.

Please let me know if I can be of any help on this. Thanks!

[David M]

patch for 12630 -- appears to be a typo

[David M]

upon further investigation, it seems like there was a very old copy-paste bug in this control? line 259 had resize setting: this._currentState = dim;

instead of: this._naturalState = dim;

I searched through the entire code base, and I don't see '_currentState' used anywhere, so I'm assuming it was changed some time ago. Does this look like a good patch?

[bill]

Trivial patch so no CLA needed but if you want to file bigger patches please file ​http://dojofoundation.org/about/cla, thanks! Forwarding bug to Pete, this is dojox.layout not dijit.

[David M]

Ah, oops! Thanks for forwarding that along. We have CLA's with some other open source projects, I'll look into getting one with dojo.

Thanks again

[bill]

Moving apparently forgotten ticket to 1.8.

[Colin Snover]

1.8 has been tagged; moving all outstanding tickets to next major release milestone.

[Colin Snover <github.com@…>]

In c54ddadfd71d3bec1e966a913a4c548ef5145d4c/dojox:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Colin Snover <github.com@…>]

In 2766831ea1525be761751077b933f9c716123507/dojox:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Colin Snover <github.com@…>]

In bece9cc25e55366eb4df2db41130ed2a06b5a526/dojox:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Colin Snover <github.com@…>]

In 286251fa36cc5bcbcbe64dc2bfbd862cea06d0c1/dojox:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Colin Snover <github.com@…>]

In c714c6f7254d21c669bbe6e291bef18c23b46abd/dojox:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Colin Snover <github.com@…>]

In e06bc41a561fbf0c69b0011bba56c57021e1c54a/dojox:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Colin Snover <github.com@…>]

In ce394b1794b0c873cd21908bca5d04987732aef8/dojox:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?