Context Navigation

← Previous Ticket
Next Ticket →

#12630 closed defect (fixed)

[regression] dojox.Layout.FloatingPane is moved / resized on browser window resize when it shouldn't be

Reported by:	David M	Owned by:	dante
Priority:	high	Milestone:	1.5.4
Component:	DojoX Layout	Version:	1.6.0
Keywords:		Cc:
Blocked By:		Blocking:

Description (last modified by bill)

Regression from 1.5. If you open the nightly floating pane tests: http://archive.dojotoolkit.org/nightly/checkout/dojox/layout/tests/test_FloatingPane.html

and compare it to an older version: http://archive.dojotoolkit.org/dojo-2010-05-01/checkout/dojox/layout/tests/test_FloatingPane.html

Steps to reproduce:

grab any floating pane
move it
dock it
resize the browser window
undock it

Observed Behavior: Floating panes seem to move / dock to top left corner, in some situations they are resized to width/height 0/0px (sometimes the dim passed to 'resize' is undefined). They do not move back to where they were before being docked, etc.

Expected Behavior: (see older unit test page) They should stay where they were / not be resized, (in my app I observed both moving to the left, and sometimes being resized to 0/0). The behavior in the previous version seems more desirable.

Please let me know if I can be of any help on this. Thanks!

Attachments (1)

floatingPane_12630.patch (521 bytes) - added by David M 10 years ago.: patch for 12630 -- appears to be a typo

Download all attachments as: .zip

Change History (15)

Changed 10 years ago by David M

Attachment:	floatingPane_12630.patch added

patch for 12630 -- appears to be a typo

comment:1 Changed 10 years ago by David M

upon further investigation, it seems like there was a very old copy-paste bug in this control? line 259 had resize setting: this._currentState = dim;

instead of: this._naturalState = dim;

I searched through the entire code base, and I don't see '_currentState' used anywhere, so I'm assuming it was changed some time ago. Does this look like a good patch?

comment:2 Changed 10 years ago by bill

Component:	Dijit → DojoX Layout
Description:	modified (diff)
Summary:	regression from 1.5 - dojox.Layout.FloatingPane is moved / resized on browser window resize when it shouldn't be → [regression] dojox.Layout.FloatingPane is moved / resized on browser window resize when it shouldn't be

Trivial patch so no CLA needed but if you want to file bigger patches please file http://dojofoundation.org/about/cla, thanks! Forwarding bug to Pete, this is dojox.layout not dijit.

comment:3 Changed 10 years ago by bill

Description:	modified (diff)
Milestone:	tbd → 1.6.1
Owner:	set to dante

comment:4 Changed 10 years ago by David M

Ah, oops! Thanks for forwarding that along. We have CLA's with some other open source projects, I'll look into getting one with dojo.

Thanks again

comment:5 Changed 9 years ago by bill

Milestone:	1.6.2 → 1.8

Moving apparently forgotten ticket to 1.8.

comment:6 Changed 9 years ago by Colin Snover

Milestone:	1.8 → 2.0

1.8 has been tagged; moving all outstanding tickets to next major release milestone.