Opened 9 years ago

Closed 5 years ago

Last modified 5 years ago

#12630 closed defect (fixed)

[regression] dojox.Layout.FloatingPane is moved / resized on browser window resize when it shouldn't be

Reported by: David M Owned by: dante
Priority: high Milestone: 1.5.4
Component: DojoX Layout Version: 1.6.0
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

Regression from 1.5. If you open the nightly floating pane tests: http://archive.dojotoolkit.org/nightly/checkout/dojox/layout/tests/test_FloatingPane.html

and compare it to an older version: http://archive.dojotoolkit.org/dojo-2010-05-01/checkout/dojox/layout/tests/test_FloatingPane.html

Steps to reproduce:

  1. grab any floating pane
  2. move it
  3. dock it
  4. resize the browser window
  5. undock it

Observed Behavior: Floating panes seem to move / dock to top left corner, in some situations they are resized to width/height 0/0px (sometimes the dim passed to 'resize' is undefined). They do not move back to where they were before being docked, etc.

Expected Behavior: (see older unit test page) They should stay where they were / not be resized, (in my app I observed both moving to the left, and sometimes being resized to 0/0). The behavior in the previous version seems more desirable.

Please let me know if I can be of any help on this. Thanks!

Attachments (1)

floatingPane_12630.patch (521 bytes) - added by David M 9 years ago.
patch for 12630 -- appears to be a typo

Download all attachments as: .zip

Change History (15)

Changed 9 years ago by David M

Attachment: floatingPane_12630.patch added

patch for 12630 -- appears to be a typo

comment:1 Changed 9 years ago by David M

upon further investigation, it seems like there was a very old copy-paste bug in this control? line 259 had resize setting: this._currentState = dim;

instead of: this._naturalState = dim;

I searched through the entire code base, and I don't see '_currentState' used anywhere, so I'm assuming it was changed some time ago. Does this look like a good patch?

comment:2 Changed 9 years ago by bill

Component: DijitDojoX Layout
Description: modified (diff)
Summary: regression from 1.5 - dojox.Layout.FloatingPane is moved / resized on browser window resize when it shouldn't be[regression] dojox.Layout.FloatingPane is moved / resized on browser window resize when it shouldn't be

Trivial patch so no CLA needed but if you want to file bigger patches please file http://dojofoundation.org/about/cla, thanks! Forwarding bug to Pete, this is dojox.layout not dijit.

comment:3 Changed 9 years ago by bill

Description: modified (diff)
Milestone: tbd1.6.1
Owner: set to dante

comment:4 Changed 9 years ago by David M

Ah, oops! Thanks for forwarding that along. We have CLA's with some other open source projects, I'll look into getting one with dojo.

Thanks again

comment:5 Changed 8 years ago by bill

Milestone: 1.6.21.8

Moving apparently forgotten ticket to 1.8.

comment:6 Changed 7 years ago by Colin Snover

Milestone: 1.82.0

1.8 has been tagged; moving all outstanding tickets to next major release milestone.

comment:7 Changed 5 years ago by Colin Snover <github.com@…>

Resolution: fixed
Status: newclosed

In c54ddadfd71d3bec1e966a913a4c548ef5145d4c/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:7 Changed 5 years ago by Colin Snover <github.com@…>

Resolution: fixed
Status: newclosed

In 2766831ea1525be761751077b933f9c716123507/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:8 Changed 5 years ago by Colin Snover <github.com@…>

In bece9cc25e55366eb4df2db41130ed2a06b5a526/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:8 Changed 5 years ago by Colin Snover <github.com@…>

In 286251fa36cc5bcbcbe64dc2bfbd862cea06d0c1/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:9 Changed 5 years ago by Colin Snover <github.com@…>

In c714c6f7254d21c669bbe6e291bef18c23b46abd/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:8 Changed 5 years ago by Colin Snover <github.com@…>

In e06bc41a561fbf0c69b0011bba56c57021e1c54a/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:9 Changed 5 years ago by Colin Snover <github.com@…>

In ce394b1794b0c873cd21908bca5d04987732aef8/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:10 Changed 5 years ago by Colin Snover

Milestone: 2.01.5.4
Note: See TracTickets for help on using tickets.