Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#12627 closed defect (fixed)

IE9: formatBlock translation logic in editor is failing.

Reported by: Jared Jurkiewicz Owned by: Jared Jurkiewicz
Priority: high Milestone: 1.5.2
Component: Editor Version: 1.6.0
Keywords: IE9 Editor Cc: bill
Blocked By: Blocking:

Description (last modified by bill)

IE9: formatBlock translation logic in editor is failing.

The localizeEditorBlockNames function in RichText.js fails in IE9 (And IE9 in IE8 mode). Fixes are required in both selection.js and RichText.js

Change History (14)

comment:1 Changed 9 years ago by Jared Jurkiewicz

Cc: bill added
Owner: set to Jared Jurkiewicz

comment:2 Changed 9 years ago by Jared Jurkiewicz

(In [24240]) Trying to fix selection/etc issues. !strict refs #12627

comment:3 Changed 9 years ago by Jared Jurkiewicz

(In [24244]) Trying to fix selection/etc issues. More fixes to IE9. !strict refs #12627

comment:4 Changed 9 years ago by Jared Jurkiewicz

(In [24245]) Trying to fix selection/etc issues. 1.6.1 fixes (backports). !strict refs #12627

comment:5 Changed 9 years ago by Jared Jurkiewicz

Keywords: IE9 Editor added

comment:6 Changed 9 years ago by bill

Description: modified (diff)

Trac missed these:

  • (In [24244]) Trying to fix selection/etc issues. More fixes to IE9. !strict refs #12627
  • (In [24242]) Trying to fix selection/etc issues. Removing extraneous console.log. !strict refs #12627
  • (In [24240]) Trying to fix selection/etc issues. !strict refs #12627
  • (In [24245]) Trying to fix selection/etc issues. 1.6.1 fixes (backports). !strict refs #12627

comment:7 Changed 9 years ago by Jared Jurkiewicz

Resolution: fixed
Status: newclosed

comment:8 Changed 8 years ago by liucougar

Resolution: fixed
Status: closedreopened

(In [24245]) addElement is not available on IE controlRange

it seems we don't have tests to actually exercise that code path at all

comment:9 Changed 8 years ago by Jared Jurkiewicz

Resolution: fixed
Status: reopenedclosed

There is a try/catch on that block. So if the control range tails, it just goes into the exception handler. This is intentional. The load tests have been used to check this works reasonably okay on IE and I believe is tested by the InsetrLink? plugin when dealing with images

comment:10 Changed 8 years ago by Jared Jurkiewicz

I'll recheck it, but as far as I know at this time, the code is working adequately.

comment:12 Changed 8 years ago by Jared Jurkiewicz

comment:13 Changed 8 years ago by liucougar

sorry, I meant to say: "addElement is only available on IE controlRange ", it's not available on textRange

comment:14 Changed 8 years ago by Kenneth G. Franqueiro

Milestone: 1.6.11.5.2

Updating milestone to 1.5.2 to reflect inclusion in changeset [26956] for ticket #14199.

Note: See TracTickets for help on using tickets.