#12620 closed defect (fixed)
[patch][ccla]svg2gfx.xsl may not compile because of invalid 'mode' attributes
Reported by: | Patrick Ruzand | Owned by: | Eugene Lazutkin |
---|---|---|---|
Priority: | high | Milestone: | 1.7 |
Component: | DojoX GFX | Version: | 1.6.0 |
Keywords: | Cc: | pruzand@… | |
Blocked By: | Blocking: |
Description
The svg2gfx.xsl defines several <xsl:template> elements with a 'mode' attribute. This goes against the XSL specification that clearly states a 'mode' attribute cannot be set on an element that does not have a 'match' attribute. see: http://www.w3.org/TR/xslt#modes
Note: Compiling the xsl with xsl4j gives the following error: An xsl:template element must have either a 'match' attribute or a 'name' attribute, or both. An xsl:template element that has no 'match' attribute must have no 'mode' attribute and no 'priority' attribute.
Attachments (1)
Change History (4)
Changed 9 years ago by
Attachment: | 12620.patch added |
---|
comment:1 Changed 9 years ago by
The patch looks fine. I confess I forget why I put those modes into those utility routines originally. They seem to date from some of my earliest work in there, so it's likely that they're a relic from the period where I'd planned on updating the old version rather than more or less rewriting it, and are thus residue from an abandoned design.
Anyhow, I've tested it with xsltproc on some of my old test files and see no difference in output.
comment:2 Changed 9 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:3 Changed 9 years ago by
Milestone: | tbd → 1.7 |
---|
patch: remove all 'mode' attributes