Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#12620 closed defect (fixed)

[patch][ccla]svg2gfx.xsl may not compile because of invalid 'mode' attributes

Reported by: Patrick Ruzand Owned by: Eugene Lazutkin
Priority: high Milestone: 1.7
Component: DojoX GFX Version: 1.6.0
Keywords: Cc: pruzand@…
Blocked By: Blocking:

Description

The svg2gfx.xsl defines several <xsl:template> elements with a 'mode' attribute. This goes against the XSL specification that clearly states a 'mode' attribute cannot be set on an element that does not have a 'match' attribute. see: http://www.w3.org/TR/xslt#modes

Note: Compiling the xsl with xsl4j gives the following error: An xsl:template element must have either a 'match' attribute or a 'name' attribute, or both. An xsl:template element that has no 'match' attribute must have no 'mode' attribute and no 'priority' attribute.

Attachments (1)

12620.patch (3.9 KB) - added by Patrick Ruzand 8 years ago.
patch: remove all 'mode' attributes

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by Patrick Ruzand

Attachment: 12620.patch added

patch: remove all 'mode' attributes

comment:1 Changed 8 years ago by Feneric

The patch looks fine. I confess I forget why I put those modes into those utility routines originally. They seem to date from some of my earliest work in there, so it's likely that they're a relic from the period where I'd planned on updating the old version rather than more or less rewriting it, and are thus residue from an abandoned design.

Anyhow, I've tested it with xsltproc on some of my old test files and see no difference in output.

comment:2 Changed 8 years ago by Chris Mitchell

Resolution: fixed
Status: newclosed

(In [24701]) fixes #12620 remove invalid mode attributes from svg2gfx.xsl !strict

comment:3 Changed 8 years ago by bill

Milestone: tbd1.7
Note: See TracTickets for help on using tickets.