Opened 10 years ago
Closed 9 years ago
#12593 closed defect (wontfix)
dojox.cometd.RestChannels - disconnect()
Reported by: | grant.s | Owned by: | Kris Zyp |
---|---|---|---|
Priority: | high | Milestone: | tbd |
Component: | DojoX Cometd | Version: | 1.6.0 |
Keywords: | RestChannels disconnect | Cc: | |
Blocked By: | Blocking: |
Description
The disconnect() method of dojox.cometd.RestChannels? attempts to call this.xhr.abort() but this.xhr is undefined (I can't find anywhere in the code where this.xhr is assigned). The result is that a pending xhr request is not aborted and when the pending request completes, the RestChannels?.defaultInstance object automatically reconnects again.
Attachments (1)
Change History (7)
Changed 10 years ago by
Attachment: | RestChannels.js added |
---|
comment:1 follow-up: 2 Changed 10 years ago by
I've made an attempt at fixing this myself so that I can get past the problem - updated source file attached. It now allows you to call disconnect() and then open() if you want to start the connection, however, if you call subscribe() when disconnected then the automatic re-connect doesn't work properly (I think the 2 xhr requests get confused)... so, it needs some more attention to get it right.
comment:2 Changed 10 years ago by
Sorry, I've definitely broken something in my version as it's no longer working with JsonRestStore?.
comment:3 Changed 10 years ago by
Resolution: | → wontfix |
---|
closing as wontfix, as cometd client is now maintained at cometd.org. query will be sent to cometd team/Simone Bordet for review by cometd project leads
comment:4 Changed 10 years ago by
Owner: | changed from Greg Wilkins to kriszyp |
---|
Assigning to Kris. This would need to be done against the cometd project's version of the client. They're interested, but want to know the status of the spec. to follow that for making sure the implementation works as expected.
This won't make the cut-off for 1.7, so marking as tbd.
comment:5 Changed 10 years ago by
Owner: | changed from kriszyp to Kris Zyp |
---|
comment:6 Changed 9 years ago by
Status: | new → closed |
---|
Partly-fixed RestChannels? source