dojox.grid.enhanced._Events bug

[patrickzope]

The constructor for dojox.grid.enhanced._Events contains the following code:

for(var p in this._events){
    if(!this[p]){
        this.p = this._events.p;
    }
}

Surely this is not the intended behavior (assigning the non-existent "p" attribute of "this._events" to this.p).

[evan]

Hi Patrick,

The logic should be correct - it intends to iterate this._events and copy properties into 'this'(if the properties are missed in 'this').

I'm closing it, please reopen if you've noticed any error observations on test cases.

Thanks!

[patrickzope]

The code is incorrect.

If intended behavior is as you described, it should look like:

for(var p in this._events){
    if(!this[p]){
        this[p] = this._events[p];
    }
}

[evan]

Oh, yep, should have taken a more close look, thanks, Patrick! I'll also remove that block since it seems to be obsolete.

[evan]

(In [25479]) Fixes #12578 by removing obsolete lines