Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#12561 closed defect (fixed)

[patch][ccla]dojox.gfx.canvas.Surface.setDimensions performs unnecessary resizing resulting in blinking effect on mobile

Reported by: Patrick Ruzand Owned by: Chris Mitchell
Priority: high Milestone: 1.7
Component: DojoX GFX Version: 1.6.0
Keywords: 1.7-mobile Cc:
Blocked By: Blocking:

Description

The current implementation of Surface.setDimensions() does not check the new size wrt the current size. If the sizes are the same, this unnecessary resizing results in blinking effects on mobile.

Attachments (3)

12561.patch (607 bytes) - added by Patrick Ruzand 9 years ago.
12561.2.patch (637 bytes) - added by Patrick Ruzand 9 years ago.
fix base dir
12561.3.patch (779 bytes) - added by Patrick Ruzand 9 years ago.
improve fix to avoid the makeDirty() call if no resize has been done

Download all attachments as: .zip

Change History (10)

Changed 9 years ago by Patrick Ruzand

Attachment: 12561.patch added

comment:1 Changed 9 years ago by Patrick Ruzand

Code by Stephane Lizeray (IBM, CCLA)

comment:2 Changed 9 years ago by Chris Mitchell

Summary: dojox.gfx.canvas.Surface.setDimensions performs unnecessary resizing resulting in blinking effect on mobile[patch][ccla]dojox.gfx.canvas.Surface.setDimensions performs unnecessary resizing resulting in blinking effect on mobile

comment:3 Changed 9 years ago by Patrick Ruzand

new patch: fix patch base directory (base dir. was dojox/gfx/, now root of dojox/)

Changed 9 years ago by Patrick Ruzand

Attachment: 12561.2.patch added

fix base dir

Changed 9 years ago by Patrick Ruzand

Attachment: 12561.3.patch added

improve fix to avoid the makeDirty() call if no resize has been done

comment:4 Changed 9 years ago by Patrick Ruzand

Note: in case the patch 7782 (add input events support to canvas) is applied, this patch (12561) must be applied *after* 7782

comment:5 Changed 9 years ago by Chris Mitchell

Owner: changed from Eugene Lazutkin to Chris Mitchell
Status: newassigned

comment:6 Changed 9 years ago by Chris Mitchell

Resolution: fixed
Status: assignedclosed

fixed with [24515]

comment:7 Changed 9 years ago by Chris Mitchell

will need to refractor 7782 now that this one is integrated.

Note: See TracTickets for help on using tickets.