Opened 9 years ago

Closed 9 years ago

#12541 closed defect (wontfix)

AMD module definition does not accept module id in single quotes

Reported by: ovi Owned by: Rawld Gill
Priority: high Milestone: 1.7
Component: BuildSystem Version: 1.6.0
Keywords: Cc:
Blocked By: Blocking:

Description

Line 113 in util/buildscripts/jslib/fileUtil.js rejects a module definition like:

define('module_id',[deps...]

but accepts:

define("module_id",[deps...]

A simple fix is to replace the current line:

if(moduleId || contents.substring(0, 8) == "define(\""){

with:

if(moduleId || contents.substring(0, 7) == "define("){

Change History (3)

comment:1 Changed 9 years ago by bill

Owner: changed from James Burke to Rawld Gill

This will all be changed shortly with the new AMD loader so I don't think it's worth fixing.

comment:2 Changed 9 years ago by Rawld Gill

Milestone: tbd1.7
Status: newassigned

comment:3 Changed 9 years ago by Rawld Gill

Resolution: wontfix
Status: assignedclosed

see #11919; No further changes will be made to the 1.6- build system. The v1.7 build system includes native support for amd modules.

Note: See TracTickets for help on using tickets.