#12523 closed defect (wontfix)
Dialog from <a href="javascript not work in firefox
Reported by: | fabioginzel | Owned by: | |
---|---|---|---|
Priority: | high | Milestone: | tbd |
Component: | Dijit | Version: | 1.6.0 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
In firefox 3.6 and dojo 1.6.0 this not work:
var dialog = new dijit.Dialog......
<a href="javascript : dialog.show()"> show</a>
Attachments (1)
Change History (9)
comment:1 Changed 10 years ago by
Component: | General → Dijit |
---|---|
Resolution: | → worksforme |
Status: | new → closed |
Changed 10 years ago by
Attachment: | dialogError.htm added |
---|
comment:2 Changed 10 years ago by
Resolution: | worksforme |
---|---|
Status: | closed → reopened |
comment:4 Changed 10 years ago by
Resolution: | → wontfix |
---|---|
Status: | reopened → closed |
comment:6 Changed 10 years ago by
OK, I'm having trouble adding comments to this ticket, trying again.
FF seems temperamental with having an href where the expression evaluates to anything other than undefined.
In other words, this works fine:
<a href="javascript:dialog.show() && undefined">Esqueci minha senha</a>
comment:7 Changed 10 years ago by
The recommended way to do this though is to not use <a> tags at all unless you want actual hyperlinks, and if you do use <a> tags then do something like:
<a href="" onclick="dialog.show(); dojo.stopEvent(arguments[0]);">click</a>
comment:8 Changed 10 years ago by
It's true that in 1.6 Dialog.show() got a return value, and unfortunately that will break code like yours, but I don't think we want to remove that new feature. I will add the info to the release notes though. Thanks for pointing out the issue.
We have tests for this (ex: dijit/tests/Dialog.html) that are working fine, so probably there's something wrong on your end, but if you can make a test file that reproduces the problem then please attach it and reopen this ticket.