Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#12520 closed defect (fixed)

[regression] ComboBox: onClick does not fire when the button portion of the widget is clicked

Reported by: kary4th Owned by: bill
Priority: high Milestone: 1.6.1
Component: Dijit - Form Version: 1.6.0
Keywords: Cc:
Blocked By: Blocking:

Description

Using dojo 1.6, onClick events are not firing unless the user clicks into the input field portion of the widget. When the button portion is clicked (causing the dropdown component of the widget to open), onclick code isn't run. Switching between dojo 1.5 and 1.6, 1.6 clearly functions differently.

new dijit.form.ComboBox({
	store: new dojo.data.ItemFileReadStore({
		data: cityJson
	}),
	autoComplete: true,
	query: {
		state: "*"
	},
	style: "width: 150px;",
	required: false,
	id: "city",
	onClick: function(){
		userChangingFieldStr = "city";
	},
	onChange: function(city) {

...etc.

Change History (6)

comment:1 Changed 9 years ago by Douglas Hays

Component: Dijit - FormDijit
Milestone: tbd1.6.1
Owner: changed from Douglas Hays to bill

Started with [22660]

comment:2 Changed 9 years ago by bill

Summary: onClick of FilteringSelect, ComboBox do not fire when the button portion of the widget is clicked.[regression] ComboBox: onClick does not fire when the button portion of the widget is clicked

Ah, thanks [22660] strikes again.

comment:3 Changed 9 years ago by bill

Resolution: fixed
Status: newclosed

(In [24141]) For the sake of backwards compatibility, make onClick() fire for clicks on down arrow, and let that click event propagate (i.e. don't call dojo.stopEvent()). In 2.0 though I don't want to spend bytes supporting esoteric events like ComboBox.onClick at all. Fixes #12520, refs #9945 !strict on 1.6/ branch.

comment:4 Changed 9 years ago by bill

(In [24143]) For the sake of backwards compatibility, make onClick() fire for clicks on down arrow, and let that click event propagate (i.e. don't call dojo.stopEvent()). In 2.0 though I don't want to spend bytes supporting esoteric events like ComboBox.onClick at all. Fixes #12520, refs #9945 !strict on trunk.

comment:5 Changed 9 years ago by bill

Component: DijitDijit - Form

comment:26 Changed 8 years ago by bill

In [26504]:

Update test file: for the deferred-connect around advice on dojo.connect() to trigger, need to use the "dojo" inside the iframe, not the "dojo" of the test runner. Refs #12520, #12451 !strict.

Note: See TracTickets for help on using tickets.