Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#12517 closed defect (fixed)

[regression] ComboBox: drag select works poorly

Reported by: bill Owned by: bill
Priority: high Milestone: 1.6.1
Component: Dijit - Form Version: 1.6.0
Keywords: Cc:
Blocked By: Blocking:

Description

Not sure who broke this, but in ​1.5.0 you can:

  1. mouse-down on the ComboBox arrow
  2. move your mouse to an item (like California)
  3. mouse up to select the item

In addition, as you move your mouse over the various items they will be highlighted.

In ​1.6.0 and trunk it sort of works but all the items behind the drop down get highlighted in addition to every single item in the drop down being highlighted.

Tested on chrome/mac.

Change History (7)

comment:1 Changed 8 years ago by Douglas Hays

Component: Dijit - Form → Dijit
Owner: Douglas Hays deleted

This started happening with [22660]. ComboBox?'s _onArrowMouseDown was removed which did a dojo.stopEvent and replaced with _HasDropDown's _onDropDownMouseDown that does not call stopEvent, which triggers the text selection when the event bubbles.

comment:2 Changed 8 years ago by Douglas Hays

Owner: set to bill

comment:3 Changed 8 years ago by bill

Resolution: → fixed
Status: new → closed

(In [24131]) missing stopEvent() call for mouse down in _HasDropDown, fixes #12517 on trunk/ !strict

comment:4 Changed 8 years ago by bill

(In [24132]) missing stopEvent() call for mouse down in _HasDropDown, fixes #12517 on 1.6/ branch !strict

comment:5 Changed 8 years ago by bill

Component: Dijit → Dijit - Form

comment:6 Changed 7 years ago by bill

stopEvent() changed to preventDefault() in [27394] on trunk, [27410] on 1.7 branch, but needs backport to 1.6 branch.

comment:7 Changed 7 years ago by bill

In [28814]:

Backport [27394] to 1.6 branch, using preventDefault() rather than stopEvent(), fixes #13790, refs #12517, #14408, #14410 !strict.

Note: See TracTickets for help on using tickets.