Opened 8 years ago

Closed 8 years ago

#12491 closed defect (fixed)

dojo/store/Observable is missing a dependency

Reported by: ben hockey Owned by: Kris Zyp
Priority: high Milestone: 1.6.1
Component: Data Version: 1.6.0
Keywords: Cc:
Blocked By: Blocking:

Description

dojo/store/Observable tries to assign to dojo.store.Observable but only declares a dependency on "dojo". this means that dojo.store is not guaranteed to exist as a namespace when the assignment happens.

i would offer a patch but there's a number of ways to fix this and not sure which is preferred. they're all fairly trivial.

Change History (8)

comment:1 Changed 8 years ago by ben hockey

probably a simple dojo.getObject is all that might be needed.

comment:2 Changed 8 years ago by Kris Zyp

Resolution: → fixed
Status: new → closed

(In [24222]) Make sure dojo.store is there, fixes #12491

comment:3 Changed 8 years ago by Kris Zyp

Should this go in 1.6.1?

comment:4 in reply to:  3 Changed 8 years ago by ben hockey

Milestone: tbd → 1.6.1
Resolution: fixed
Status: closed → reopened

Replying to kzyp:

Should this go in 1.6.1?

i would think so - it doesn't introduce anything new. it's basically fixing a typo. i'll reopen it and mark it with the 1.6.1 milestone

comment:5 Changed 8 years ago by ben hockey

btw, the same problem is in dojo/store/Cache

comment:6 Changed 8 years ago by Kris Zyp

(In [24237]) Make sure dojo.store namespace exists, refs #12491

comment:7 Changed 8 years ago by Kris Zyp

(In [24239]) backport fixes from refs #12491, refs #12597, and refs #11537

comment:8 Changed 8 years ago by bill

Resolution: → fixed
Status: reopened → closed
Note: See TracTickets for help on using tickets.