dojo.query on xml nodes in IE

[aurelien.baudet]

dojo.query fails when trying to access direct children using '>' selector on xml content in IE. It throws an error in this code:

var te, x = 0, tret = root[childNodesName]

It tries to get rootchildren? but it's not defined... The bug comes from childNodesName because it values "children" and not "childNodes" due to the code below that tests if children is available but on dojo.doc and not on the real document of the node:

	var childNodesName = !!getDoc().firstChild["children"] ? "children" : "childNodes";

and getDoc:

	var getDoc = function(){ return d.doc; };

I attached a file in order to reproduce the bug easily.

[aurelien.baudet]

possible fix

[aurelien.baudet]

I found a possible correction but it needs more tests and check performances (file attached): line 148

	var childNodesName = function(root) { return !!root.firstChild["children"] ? "children" : "childNodes"; };

line 594

			tret = root[childNodesName(root)],

line 875

			var te, x = 0, tret = root[childNodesName(root)];

[aurelien.baudet]

Oups I made an error in my correction:

line 148

var childNodesName = function(root) { return !!root["children"] ? "children" : "childNodes"; };

And the doh test for dojo.query pass with this correction

[Chris Mitchell]

please review/triage

[Kris Zyp]

(In [25510]) Use per element determination of children vs childNodes, fixes #12488 !strict

[Colin Snover <[email protected]…>]

In c67ea3e7a6463c8d5479b0c88007cd2c0c86443c/dojo:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Colin Snover <[email protected]…>]

In 4b50371538c09375caf6072b7956c7a5dfd06f6b/dojo:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Colin Snover <[email protected]…>]

In 819d5cded4dc99af6144a65b058ec1708cacf975/dojo:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Colin Snover]

Surprise! 1.4.4 was actually released over a year ago.