#12485 closed defect (fixed)
[patch][ccla]TabBar - CSS Size Definition on Icon is not Honored
Reported by: | zhangyp | Owned by: | Chris Mitchell |
---|---|---|---|
Priority: | high | Milestone: | 1.7 |
Component: | DojoX Mobile | Version: | 1.6.0 |
Keywords: | 1.7-mobile | Cc: | [email protected]…, [email protected]…, [email protected]…, [email protected]…, [email protected]…, [email protected]…, [email protected]…, Evan |
Blocked By: | Blocking: |
Description
This is a bug regarding the size of the icon in TabBar?. The CSS declaration of the height and width of the icon image is not honored. Thus, if the image original size exceeds the CSS size, sometimes the icon will show in its original size. Please see the attached picture. The root cause is the following statement which is supposed to fix a drawing issue in iPhone and Safari.
this.style.width = this.width + "px"; this.style.height = this.height + "px";
The problem is that if the size is specified through CSS, then it's "this.style.width" and "this.style.height". The above code won't work.
A possible way is to use the following statements.
var originDisplay = this.style.display; this.style.display = "none"; this.style.display = originDisplay;
Letting the icon hide and show seems to fix this problem.
Attachments (1)
Change History (9)
comment:1 Changed 10 years ago by
Component: | General → DojoX Mobile |
---|---|
Owner: | changed from anonymous to ykami |
comment:2 Changed 10 years ago by
Cc: | [email protected]… [email protected]… [email protected]… [email protected]… [email protected]… [email protected]… [email protected]… added |
---|---|
Keywords: | 1.7-mobile added |
this defect is a prereq for 12415 (mobile showcase)
comment:3 Changed 10 years ago by
Summary: | TabBar - CSS Size Definition on Icon is not Honored → [patch][ccla]TabBar - CSS Size Definition on Icon is not Honored |
---|
Changed 10 years ago by
Attachment: | Fix-TabBar-Icon-Size.patch added |
---|
comment:4 Changed 10 years ago by
Owner: | changed from ykami to Chris Mitchell |
---|
comment:5 Changed 10 years ago by
Status: | new → assigned |
---|
comment:6 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
comment:7 Changed 10 years ago by
Milestone: | tbd → 1.7 |
---|
comment:8 Changed 10 years ago by
Cc: | Evan added |
---|
Sounds like you are talking about dojox.mobile