Opened 10 years ago
Closed 8 years ago
#12481 closed defect (patchwelcome)
Invalid call to cell.restore() in dojox/grid/_EditManager.js
Reported by: | nobbynobbs77 | Owned by: | Evan |
---|---|---|---|
Priority: | high | Milestone: | tbd |
Component: | DojoX Grid | Version: | 1.6.0 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
The patch illustrates the invalid call:
Index: dojox/grid/_EditManager.js =================================================================== --- dojox/grid/_EditManager.js (Revision 24064) +++ dojox/grid/_EditManager.js (Arbeitskopie) @@ -233,7 +233,7 @@ // Grid view var c = this.info.cell; if(this.isEditRow(inRowIndex) && c.view == inView && c.editable){ - c.restore(c, this.info.rowIndex); + c.restore(this.info.rowIndex); } } }); Index: dojox/grid/cells/_base.js =================================================================== --- dojox/grid/cells/_base.js (Revision 24064) +++ dojox/grid/cells/_base.js (Arbeitskopie) @@ -238,7 +238,9 @@ // restore editor state // inRowIndex: int // grid row index - this.setValue(inRowIndex, this.value); + if (this.value) { + this.setValue(inRowIndex, this.value); + } //console.log("restore", this.value, inCell.index, inRowIndex); }, //protected
Change History (3)
comment:1 Changed 9 years ago by
Owner: | changed from evan to Evan |
---|
comment:2 Changed 8 years ago by
comment:3 Changed 8 years ago by
Resolution: | → patchwelcome |
---|---|
Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
DojoX Grid and EnhancedGrid are deprecated in favor of dgrid and gridx.
You should upgrade your code to use one of those two grids.
We will consider patches to the old DojoX Grid code though.