[patch][ccla] improve dojox.charting.axis2d.Default performance by caching gfx shapes

[cjolif]

prereqs: 12392 chart interaction

Now that interactions on the chart can be added (​http://bugs.dojotoolkit.org/ticket/12392) this will be more frequent to have a dynamic axis that is re-rendered several times. This is causing slowness issues on:

• Desktop FF 3.x

• IE 6,7,8

• Safari Mobile

There us not much we can do for IE, however caching the gfx shapes for FF & Safari Mobile is giving some noticeable performance gain (see [​https://docs.google.com/document/d/1WM1UeXGZKgUSzL94TzRbr3dNEHiMzSJvy7pZep8yyAw/edit?hl=fr&authkey=CL7IjbIM#bookmark=id.mahfzhlpk7ay ])

This patch proposes an optional flag on the series to do this caching.

This patch contains a patch on a test/example provided by the interaction patch (thus the interaction patch needs to be applied first).

(code will be attached later)

[cjolif]

Per Eugene suggestion, I have updated the patch to use Array.pop() instead of Array.shift() in the pools.

This one can be deleted (forgot to check "replace attachment): ​http://bugs.dojotoolkit.org/attachment/ticket/12464/axisperfwithoutdemo.2.patch

[cjolif]

It seems my new upload to include the shift->pop change did not work. I'll try to re-attached the file once more.

[cjolif]

The shift->pop modification is now correctly in the latest patch version

[Chris Mitchell]

[24538] fixes this issue. Apparently multiple ticket numers in a "fix" commit string mess up auto-closing trac tickets.

[Eugene Lazutkin]

Replying to chrism:

[24538] fixes this issue. Apparently multiple ticket numers in a "fix" commit string mess up auto-closing trac tickets.

Sometimes the robot who updates tickets goes down.

[bill]

The patch in [24538] has a typo:

// go out nicely instead of try/catch
if(t==null){
	this.diry = false;
	return;
}

It should be this.dirty. Also, you need to return a value, probably return this?

[cjolif]

fix for typo/return type

[Chris Mitchell]

In [26359]:

fixes #12464 fix typo and return val in axis2d.Default. Thx cjolif @ IBM \!strict