#1245 closed defect (fixed)
docIcon has 3px gap in IE
Reported by: | ornus | Owned by: | ilia |
---|---|---|---|
Priority: | high | Milestone: | |
Component: | General | Version: | 0.3 |
Keywords: | tree docIcon | Cc: | |
Blocked By: | Blocking: |
Description
There's a gap in IE between icons that breaks the grid. It is caused by the floated TreeExpand? div.
http://www.positioniseverything.net/explorer/threepxtest.html describes the problem.
Attachments (7)
Change History (15)
Changed 15 years ago by
Attachment: | treeV3_11.patch added |
---|
comment:1 Changed 15 years ago by
This patch works on the first sight, but I don't like it. Changing position mode can have unforeseen side effects, slow downs in calculating position in dnd, slow down with big tree, layout complications, etc. I don't know if there will be any problems, but I really would prefer to have a different solution.
comment:2 Changed 15 years ago by
This patch assumes there's a 3px gap and compensates by making expand picture smaller. There's still a horizontal gap, but vertical grid is alligned.
The best solution would be to use
margin-left: -3px;
but for whatever reason it doesn't work.
comment:3 Changed 15 years ago by
Maybe it's better not to have vertical line for multi-line nodes? It's not a big deal.
I guess the best solution would be to allew user to specify if he wants vertical line at price of gaps? But that's too much extra work.
comment:4 Changed 15 years ago by
Last patch removes the gap by setting
margin-right: -3px;
on the floated TreeExpanded? icon. It seems to work the best.
Changed 15 years ago by
Attachment: | treeV3_11.5.patch added |
---|
Alternative patch that uses different layout.
comment:5 Changed 15 years ago by
The last patch changes layout slightly. It adds a div around all icons and content, next to the container:
<div class="TreeContentWrapper"> <div class="TreeExpand></div><div class="TreeIconContent"><TreeIcon><TreeContent></div> </div> <div class="TreeContainer"> </div>
This let's us set height: 18px on the TreeContentWrapper?. The gap is between floated div and a div with height: 18px, but all floatet images are inside - no gap.
There are +s and -s. Expand all operation is about 25% faster than when using margin-right: -3px. Probably IE has less to recalc. YAY!
On the negative side Empty Folder now has a bug. See docIcon1.html. The bug will only show itself when empty folder is next to the last. It's minor, ehh. I'll take tree being faster than fix for this bug:)
comment:6 Changed 15 years ago by
It's probably a good idea to clean HTML somewhat. There are too many divs. Not sure we need all of them.
Changed 15 years ago by
Attachment: | treeV3_11.7.patch added |
---|
Refactored and cleaned up code and css.
comment:7 Changed 15 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
Fix through position: relative