docIcon has 3px gap in IE

[ornus]

There's a gap in IE between icons that breaks the grid. It is caused by the floated TreeExpand? div.

​http://www.positioniseverything.net/explorer/threepxtest.html describes the problem.

[ornus]

Fix through position: relative

[ornus]

This patch works on the first sight, but I don't like it. Changing position mode can have unforeseen side effects, slow downs in calculating position in dnd, slow down with big tree, layout complications, etc. I don't know if there will be any problems, but I really would prefer to have a different solution.

[ornus]

Alternative patch.

[ornus]

This patch assumes there's a 3px gap and compensates by making expand picture smaller. There's still a horizontal gap, but vertical grid is alligned.

The best solution would be to use

margin-left: -3px;

but for whatever reason it doesn't work.

[ornus]

Maybe it's better not to have vertical line for multi-line nodes? It's not a big deal.

I guess the best solution would be to allew user to specify if he wants vertical line at price of gaps? But that's too much extra work.

[ornus]

Working patch.

[ornus]

Last patch removes the gap by setting

margin-right: -3px;

on the floated TreeExpanded? icon. It seems to work the best.

[ornus]

patch

[ornus]

Alternative patch that uses different layout.

[ornus]

The last patch changes layout slightly. It adds a div around all icons and content, next to the container:

<div class="TreeContentWrapper">
   <div class="TreeExpand></div><div class="TreeIconContent"><TreeIcon><TreeContent></div>
</div>
<div class="TreeContainer">
</div>

This let's us set height: 18px on the TreeContentWrapper?. The gap is between floated div and a div with height: 18px, but all floatet images are inside - no gap.

There are +s and -s. Expand all operation is about 25% faster than when using margin-right: -3px. Probably IE has less to recalc. YAY!

On the negative side Empty Folder now has a bug. See docIcon1.html. The bug will only show itself when empty folder is next to the last. It's minor, ehh. I'll take tree being faster than fix for this bug:)

[ornus]

It's probably a good idea to clean HTML somewhat. There are too many divs. Not sure we need all of them.

[ornus]

Updated patch.

[ornus]

Refactored and cleaned up code and css.

[(none)]

Milestone 0.4 deleted