Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#12448 closed defect (fixed)

[patch] [ccla] Rich Text Editor - Hitting enter loses all font formatting when blockNodeForEnter='DIV'

Reported by: Ed Chatelain Owned by: Jared Jurkiewicz
Priority: high Milestone: 1.7
Component: Editor Version: 1.6.0
Keywords: Cc:
Blocked By: Blocking:

Description

Rich Text Editor - Hitting enter loses all font formatting when blockNodeForEnter='DIV' There is code to try to clone the style over to the new row, but the font node is not being cloned. I will include a patch with the fix in EnterKeyHandling?.js, and a patch to add a test for splitting a font in dijit/tests/editor/EnterKeyHandling.html and the EnterKeyHandling?.html robot test.

Patch from Ed (IBM, CCLA) to follow.

Attachments (3)

EnterKeyHandling.js.patch (3.1 KB) - added by Ed Chatelain 9 years ago.
EnterKeyHandling.html.patch (904 bytes) - added by Ed Chatelain 9 years ago.
Robot-EnterKeyHandling.html.patch (2.4 KB) - added by Ed Chatelain 9 years ago.

Download all attachments as: .zip

Change History (8)

Changed 9 years ago by Ed Chatelain

Attachment: EnterKeyHandling.js.patch added

Changed 9 years ago by Ed Chatelain

Attachment: EnterKeyHandling.html.patch added

Changed 9 years ago by Ed Chatelain

comment:1 Changed 9 years ago by bill

Owner: set to Jared Jurkiewicz
Summary: Rich Text Editor - Hitting enter loses all font formatting when blockNodeForEnter='DIV'[patch] [ccla] Rich Text Editor - Hitting enter loses all font formatting when blockNodeForEnter='DIV'

Jared, you want to review this?

comment:2 Changed 9 years ago by Jared Jurkiewicz

Yep, I'll review when I get some free time. On a business trip this week, so probably early next week.

comment:3 Changed 9 years ago by Jared Jurkiewicz

(In [24109]) Updates to Enter key handling for font splitting. \!strict refs #12448

comment:4 Changed 9 years ago by Jared Jurkiewicz

Resolution: fixed
Status: newclosed

(In [24110]) Updates to Enter key handling for font splitting. \!strict fixes #12448

comment:5 Changed 9 years ago by bill

Milestone: tbd1.7
Note: See TracTickets for help on using tickets.