Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#12444 closed defect (fixed)

[patch][cla]mdnd non-fucntional on IE9

Reported by: clinejm Owned by: Kenneth G. Franqueiro
Priority: high Milestone: 1.6.2
Component: Dojox Version: 1.6.0
Keywords: Cc:
Blocked By: Blocking:

Description

You can not start dragging when the funcitonal tests are loaded in IE9 RC http://archive.dojotoolkit.org/nightly/dojotoolkit/dojox/mdnd/tests/functionalTests/test_dnd_stress.html

Other browsers and older versions of IE operate normally. mdnd from version 1.5 is also non-functional GridContainer? which uses mdnd is also effected.

There looks to be some InternetExplorer? "user feature" that pops up when dragging starts.

Further investigation is needed.

Regular dojo.dnd is not effected.

IE 9 version tested: 9.0.8080.16413 Update Version: RC

Attachments (1)

12444.patch (729 bytes) - added by jbest 8 years ago.
Fixes IE9 using suggestion in comments

Download all attachments as: .zip

Change History (14)

comment:1 Changed 9 years ago by Adam Peller

Owner: changed from Adam Peller to jfcunat

comment:2 Changed 9 years ago by clinejm

Re-tested on IE9 Final. Same results.

comment:3 Changed 9 years ago by darth

http://www.quirksmode.org/js/events_properties.html#button Seems IE9 is following the standard now, with left click == 0. Movable.js has check like var isLeftButton = dojo.isIE ? (e.button == 1) : (e.which == 1); IE9 can just rely on event.which too like other browsers, so perhaps isIE < 9 should suffice.

comment:4 Changed 9 years ago by Adam Peller

Summary: mdnd non-fucntional on internet explorer 9RCmdnd non-fucntional on IE9

comment:5 Changed 9 years ago by bill

Oh, it should be calling dojo.mouseButton.isLeft().

comment:6 Changed 9 years ago by darth

Can the fix for this be made part of 1.6.1 please.

comment:7 Changed 9 years ago by Adam Peller

Milestone: tbd1.6.1

will tag for 1.6.1, but there's very little time left. It may end up in a later 1.6 release.

comment:8 Changed 8 years ago by Karl Tiedt

Just pinging this since we had questions about this specific bug in #dojo today... Seems like the fix was discussed but never implemented?

Changed 8 years ago by jbest

Attachment: 12444.patch added

Fixes IE9 using suggestion in comments

comment:9 Changed 8 years ago by jbest

I attached a patch for this using darth's suggestion. All dojox/mdnd tests pass under IE9.

comment:10 Changed 8 years ago by Adam Peller

Owner: changed from jfcunat to Eugene Lazutkin
Summary: mdnd non-fucntional on IE9[patch][cla]mdnd non-fucntional on IE9

comment:11 Changed 8 years ago by Kenneth G. Franqueiro

Owner: changed from Eugene Lazutkin to Kenneth G. Franqueiro

This can be fixed better, without browser detection at all.

var isLeftButton = (e.which || e.button) == 1;

Already applied change to 1.6 trunk and tested across all browsers. Will also apply to trunk and test there.

comment:12 Changed 8 years ago by Kenneth G. Franqueiro

Resolution: fixed
Status: newclosed

In [26810]:

Replace browser detection in mdnd/Moveable with feature detection. Fixes #12444 on 1.6 trunk

comment:13 Changed 8 years ago by Kenneth G. Franqueiro

In [26811]:

Replace browser detection in mdnd/Moveable with feature detection. Fixes #12444 on trunk

Note: See TracTickets for help on using tickets.