[patch][cla]mdnd non-fucntional on IE9

[clinejm]

You can not start dragging when the funcitonal tests are loaded in IE9 RC ​http://archive.dojotoolkit.org/nightly/dojotoolkit/dojox/mdnd/tests/functionalTests/test_dnd_stress.html

Other browsers and older versions of IE operate normally. mdnd from version 1.5 is also non-functional GridContainer? which uses mdnd is also effected.

There looks to be some InternetExplorer? "user feature" that pops up when dragging starts.

Further investigation is needed.

Regular dojo.dnd is not effected.

IE 9 version tested: 9.0.8080.16413 Update Version: RC

[clinejm]

Re-tested on IE9 Final. Same results.

[darth]

​http://www.quirksmode.org/js/events_properties.html#button Seems IE9 is following the standard now, with left click == 0. Movable.js has check like var isLeftButton = dojo.isIE ? (e.button == 1) : (e.which == 1); IE9 can just rely on event.which too like other browsers, so perhaps isIE < 9 should suffice.

[bill]

Oh, it should be calling dojo.mouseButton.isLeft().

[darth]

Can the fix for this be made part of 1.6.1 please.

[Adam Peller]

will tag for 1.6.1, but there's very little time left. It may end up in a later 1.6 release.

[Karl Tiedt]

Just pinging this since we had questions about this specific bug in #dojo today... Seems like the fix was discussed but never implemented?

[jbest]

Fixes IE9 using suggestion in comments

[jbest]

I attached a patch for this using darth's suggestion. All dojox/mdnd tests pass under IE9.

[Kenneth G. Franqueiro]

This can be fixed better, without browser detection at all.

var isLeftButton = (e.which || e.button) == 1;

Already applied change to 1.6 trunk and tested across all browsers. Will also apply to trunk and test there.

[Kenneth G. Franqueiro]

In [26810]:

Replace browser detection in mdnd/Moveable with feature detection. Fixes #12444 on 1.6 trunk

[Kenneth G. Franqueiro]

In [26811]:

Replace browser detection in mdnd/Moveable with feature detection. Fixes #12444 on trunk