Opened 11 years ago

Closed 11 years ago

Last modified 9 years ago

#12430 closed enhancement (fixed)

refactor dijit.form.CheckBox to create a lighter

Reported by: Douglas Hays Owned by: Douglas Hays
Priority: high Milestone: 1.7
Component: Dijit - Form Version: 1.6.0
Keywords: 1.7-mobile Cc: Shane O'Sullivan
Blocked By: Blocking:


Change History (5)

comment:1 Changed 11 years ago by Douglas Hays

Resolution: fixed
Status: newclosed

(In [24011]) Fixes #12430. Refactor dijit.form.CheckBox? by splitting out the function into _CheckBoxMixin.js. Use this mixin to create that does not use a template. Added a basic automated test CheckBoxMixin?.html. Same for the related RadioButton?.

comment:2 Changed 11 years ago by Douglas Hays

(In [24123]) Refs #12430. Small change to mobile checkbox test CSS

comment:3 Changed 11 years ago by bill

Component: DijitDijit - Form

comment:4 Changed 11 years ago by bill

In [27120]:

IE9 chokes on new Function("return"), stemming from onClick="return". Since this is arguable a syntax error anyway, updating the test file to have a semicolon after return, and after other statements too. Refs #12430, #14322.

comment:5 Changed 9 years ago by bill

In [30575]:

Split non-robot tests from !CheckBox_mouse.html and !CheckBox_a11y.html into new CheckBox.html non-robot test file. There might still be some overlap though with CheckBoxMixin.html. Refs #12430 tangentially, !strict.

Note: See TracTickets for help on using tickets.