Opened 8 years ago

Closed 8 years ago

#12427 closed defect (invalid)

In Safari, if there is Drag-and-Drag in side a pop up, once avatar is destroyed, pop-up will collapse

Reported by: jefhu Owned by: Eugene Lazutkin
Priority: high Milestone: tbd
Component: DnD Version: 1.4.2
Keywords: Safari DnD in popup Cc:
Blocked By: Blocking:

Description (last modified by bill)

In Safari, if there is Drag-and-Drag inside a popup, once avatar is destroyed, popup will collapse.

Firefox is working fine.

Tracing the problem, it is dojo.dnd.Manager.js stopDrag() api destroying the "Avatar" causing pop up to collapse.

dojo.dnd.Source.js onMouse() might be changed to

onMouseUp: function(e){
		// summary:
		//		event processor for onmouseup
		// e: Event
		//		mouse event
		if(this.mouseDown){
			this.mouseDown = false;
dijit.focus(this.domNode); // 	switch focus before calling dnd.Manager's onMouseUp (which calls stopDrag())
		        dojo.dnd.Source.superclass.onMouseUp.call(this, e);
		}
	},

Attachments (1)

Safari-DnD-inPopup.png (46.0 KB) - added by jefhu 8 years ago.
Attached file shows DnD inside pop-up

Download all attachments as: .zip

Change History (3)

Changed 8 years ago by jefhu

Attachment: Safari-DnD-inPopup.png added

Attached file shows DnD inside pop-up

comment:1 Changed 8 years ago by bill

Description: modified (diff)

This sounds more like a dijit problem that it should be ignoring mouseup from a drag operation.

About the code above, there's no reason to assume that this.domNode is defined, or that it's focusable. Or even that dijit is loaded.

Can you attach a test case?

comment:2 Changed 8 years ago by bill

Resolution: invalid
Status: newclosed

Closing for lack of test case, reopen if you can attach a test case.

Note: See TracTickets for help on using tickets.