FilteringSelect with client side store causes infinite recursion when setting value

[zhuxw]

Setting value to FilteringSelect? will sometimes cause infinite recursion. See dijit/form/FilteringSelect.js function _setValueAttr. When calling set("value", ...) to a FilteringSelect?, which is the standard way, this function is called. But later it'll call _callbackSetLabel in the callback of store.fetchItemByIdentity. If the store is a client side store, then at this time the _setValueAttr has not end yet. What does _callbackSetLabel do? It calls this.set("item", ...)! Here's the tricky thing, the FilteringSelect?._setItemAttr first calls its super class method, which is _AutoCompleterMixin._setItemAttr, which will call this.set("value", ...)!

So the recursion is: FilteringSelection?._setValueAttr -> FilteringSelection?._callbackSetLabel -> FilteringSelection?._setItemAttr -> _AutoCompleterMixin._setItemAttr -> FilteringSelection?._setValueAttr

This loop never ends, and finally causes "too much recursion" in Firefox.

[Douglas Hays]

This is from trunk, not 1.6.0. I need to know what revision was being tested.

[Douglas Hays]

I'm testing with [23999] and it's not happening for me. Does it only occur randomly (you mentioned "will sometimes cause")?

[Douglas Hays]

Presumed to be fixed by [23986].