Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#12416 closed enhancement (fixed)

[patch][ccla]Geo Charting Enhancements

Reported by: Chris Mitchell Owned by: Tom Trenka
Priority: high Milestone: 1.7
Component: General Version: 1.6.0rc1
Keywords: 1.7-mobile Cc: durocher.marc@…
Blocked By: Blocking:

Description

Marc and Erwan are working on enhancements to Geo charting. See their proposal/spec of work underway at https://docs.google.com/document/d/1w_ZiDMIX2GTTwjIoC8oWJEfuwHUGaFGV6vraO5F24Ts/edit?authkey=CJugmNoH&hl=en# for more details.

This ticket will include patches for the library runtime. A separate ticket is being opened to add a demo for geo charting enhancements, and to integrate the new demo into the mobile showcase gallery.

Attachments (2)

12416-geocharting.patch (37.4 KB) - added by Chris Mitchell 8 years ago.
Initial patch for geocharting. Existing test samples (in geo/charting/test folder) benefit from new features (panning, zooming - mouse or touch, improved animations,..)
12416.patch (37.5 KB) - added by Patrick Ruzand 8 years ago.
fix base dir

Download all attachments as: .zip

Change History (10)

comment:1 Changed 8 years ago by Chris Mitchell

Type: defectenhancement

comment:2 Changed 8 years ago by Chris Mitchell

Owner: changed from anonymous to Tom Trenka

Changed 8 years ago by Chris Mitchell

Attachment: 12416-geocharting.patch added

Initial patch for geocharting. Existing test samples (in geo/charting/test folder) benefit from new features (panning, zooming - mouse or touch, improved animations,..)

comment:3 Changed 8 years ago by Chris Mitchell

Summary: Geo Charting Enhancements[patch][ccla]Geo Charting Enhancements

comment:4 Changed 8 years ago by cjolif

I just had a quick look at the patch.

I would tend to not force touch interaction on mobile and mouse interaction on desktop. I think it would be better to follow what I suggested for charting (#12392) and have interactions class as public classes that are explicitely connected to the maps by the user. That way:

  • it avoids loading un-necessary classes (require)
  • it give flexibility to the user (he might need touch interaction on desktop if he has a touch screen)

comment:5 Changed 8 years ago by Patrick Ruzand

new patch: fix patch base directory (base dir. was dojox/, now root of dojox/)

Changed 8 years ago by Patrick Ruzand

Attachment: 12416.patch added

fix base dir

comment:6 Changed 8 years ago by Tom Trenka

Status: newassigned

Patch applied to trunk.

comment:7 Changed 8 years ago by Chris Mitchell

Resolution: fixed
Status: assignedclosed

this completes the enhancements planned for 1.7. geo mapping and unified geo api are tracked in separate tickets. There will be a sweep through gfx/charting/gauge modules for amd/asynch loader once the features are integrated.

comment:8 Changed 8 years ago by cjolif

Actually #12810 is also needed in 1.7 to run the new geo charting demos

Note: See TracTickets for help on using tickets.