Opened 9 years ago

Closed 8 years ago

#12405 closed enhancement (fixed)

[patch][ccla] Add bidi support to gfx

Reported by: Patrick Ruzand Owned by: Eugene Lazutkin
Priority: high Milestone: 1.7
Component: DojoX GFX Version: 1.6.0rc1
Keywords: 1.7-mobile bidi gfx Text Cc: TOMERM@…, MARIAVIN@…, Adam Peller
Blocked By: Blocking:

Description

Code from Maria Vinikov (IBM, CCLA) This patch adds bidi capabilities to gfx Text and TextPath? shapes. It is based on the BidiEngine? patch proposed in this ticket : http://bugs.dojotoolkit.org/ticket/12326.

Attachments (8)

gfxBidiSupport.patch (42.7 KB) - added by Patrick Ruzand 9 years ago.
GFXBTD_BidiSDD0_27February2011_PublicVersionpp1-10.pdf (158.0 KB) - added by tomerm 9 years ago.
Design document describing the problem and method for its' resolution (in 4 files)
GFXBTD_BidiSDD0_27February2011_PublicVersionpp11-14.pdf (144.8 KB) - added by tomerm 9 years ago.
part 2 of design doc
GFXBTD_BidiSDD0_27February2011_PublicVersionpp15-17.pdf (157.8 KB) - added by tomerm 9 years ago.
part 3 of design doc
GFXBTD_BidiSDD0_27February2011_PublicVersionpp18-20.pdf (200.0 KB) - added by tomerm 9 years ago.
part 4 of design doc
GFXBTD_BidiSDD0_27February2011_PublicVersionpp21-30.pdf (190.5 KB) - added by tomerm 9 years ago.
part 5 of design doc
GFXBTD_BidiSDD0_27February2011_PublicVersionpp31-40.pdf (155.9 KB) - added by tomerm 9 years ago.
part 6 of design doc
gfxBidiSupport.2.patch (107.9 KB) - added by Patrick Ruzand 9 years ago.
improved support for silverlight and svgweb renderers.

Download all attachments as: .zip

Change History (14)

Changed 9 years ago by Patrick Ruzand

Attachment: gfxBidiSupport.patch added

comment:1 Changed 9 years ago by tomerm

The problem we are trying to resolve is twofold:

  1. Basic reordering (different renderers have different level of Bidi support. Some of them don't provide even basic reordering of Bidi text.)
  2. Control over base text direction (allows to set base text direction to ltr/rtl/auto).

Support for control over base text direction is being added to all Dojo widgets. For core support and design document explaining what base text direction is and why it should be controlled please see following ticket: http://bugs.dojotoolkit.org/ticket/12367

I will attach another design document explaining the problem in the GFX context and the way we suggest to resolve it (this is what is implemented in the patch attached above).

Changed 9 years ago by tomerm

Design document describing the problem and method for its' resolution (in 4 files)

Changed 9 years ago by tomerm

part 2 of design doc

Changed 9 years ago by tomerm

part 3 of design doc

Changed 9 years ago by tomerm

part 4 of design doc

Changed 9 years ago by tomerm

part 5 of design doc

Changed 9 years ago by tomerm

part 6 of design doc

comment:2 Changed 9 years ago by tomerm

I had to split the design doc into 6 files since I have a limitation on the size of file I am entitled to upload (256 K only). Sorry.

comment:3 Changed 9 years ago by Adam Peller

Cc: Adam Peller added

comment:4 Changed 9 years ago by Chris Mitchell

Milestone: tbd1.7

Changed 9 years ago by Patrick Ruzand

Attachment: gfxBidiSupport.2.patch added

improved support for silverlight and svgweb renderers.

comment:5 Changed 8 years ago by Chris Mitchell

(In [24513]) refs #12405 gfx bidi support (tests)

comment:6 Changed 8 years ago by Chris Mitchell

Resolution: fixed
Status: newclosed

(In [24514]) fixes #12405 gfx bidi support (tests) !strict

Note: See TracTickets for help on using tickets.