Opened 8 years ago

Closed 6 years ago

#12400 closed defect (wontfix)

dojox.Pager store

Reported by: Wouter Hager Owned by: dante
Priority: high Milestone: 1.9
Component: DojoX Widgets Version: 1.6.0rc1
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

There are undocumented/inconsistent requirements for the Pager data store:

  1. identifier/label are ignored, instead item content key is used for pages
  2. resizeChildren will through an error if the content doesn't contain HTML (firstChild)
  1. I suggest using store.getLabel(item)
  2. I suggest set default for resizeChildren to false

Change History (4)

comment:1 Changed 8 years ago by bill

Description: modified (diff)

What code are you talking about? I see no Pager store in dijit or dojox.

comment:2 Changed 8 years ago by bill

Component: General → DojoX Widgets
Owner: changed from anonymous to dante
Summary: dojox.dijit.Pager store → dojox.Pager store

Oh nevermind, found it i dojox.widget.

comment:3 Changed 8 years ago by Wouter Hager

I've been working with this code for quite some time to try and clean it up, but I have to say the thing is a blemish on the latest release and it be better writing something from scratch using a more complete data/dijit._contained inherited api (either/or) and split into pagerVertical and pagerHorizontal. It's so far from DRY it must have come from Joe's pickled eggs jar. I'm not being helpful but I propose that this ticket be closed into oblivion. Cheers

comment:4 Changed 6 years ago by dylan

Milestone: tbd → 1.9
Resolution: → wontfix
Status: new → closed

Closing as wontfix. Let me know if you do come up with a patch for something new.

Note: See TracTickets for help on using tickets.