Opened 10 years ago
Closed 8 years ago
#12400 closed defect (wontfix)
dojox.Pager store
Reported by: | Wouter Hager | Owned by: | dante |
---|---|---|---|
Priority: | high | Milestone: | 1.9 |
Component: | DojoX Widgets | Version: | 1.6.0rc1 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description (last modified by )
There are undocumented/inconsistent requirements for the Pager data store:
- identifier/label are ignored, instead item content key is used for pages
- resizeChildren will through an error if the content doesn't contain HTML (firstChild)
- I suggest using store.getLabel(item)
- I suggest set default for resizeChildren to false
Change History (4)
comment:1 Changed 10 years ago by
Description: | modified (diff) |
---|
comment:2 Changed 10 years ago by
Component: | General → DojoX Widgets |
---|---|
Owner: | changed from anonymous to dante |
Summary: | dojox.dijit.Pager store → dojox.Pager store |
Oh nevermind, found it i dojox.widget.
comment:3 Changed 10 years ago by
I've been working with this code for quite some time to try and clean it up, but I have to say the thing is a blemish on the latest release and it be better writing something from scratch using a more complete data/dijit._contained inherited api (either/or) and split into pagerVertical and pagerHorizontal. It's so far from DRY it must have come from Joe's pickled eggs jar. I'm not being helpful but I propose that this ticket be closed into oblivion. Cheers
comment:4 Changed 8 years ago by
Milestone: | tbd → 1.9 |
---|---|
Resolution: | → wontfix |
Status: | new → closed |
Closing as wontfix. Let me know if you do come up with a patch for something new.
What code are you talking about? I see no Pager store in dijit or dojox.