Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#12393 closed enhancement (fixed)

refactor dijit.form.ComboBox to create a lighter

Reported by: Douglas Hays Owned by: Douglas Hays
Priority: high Milestone: 1.7
Component: Dijit - Form Version: 1.6.0
Keywords: 1.7-mobile Cc: Shane O'Sullivan
Blocked By: Blocking:


Change History (6)

comment:1 Changed 11 years ago by Douglas Hays

Resolution: fixed
Status: newclosed

(In [23974]) Fixes #12393. Refactor dijit.form.ComboBox? by splitting out the function into DataList?.js (inline OPTION store corresponding to HTML 5 DATALIST tag), _AutoCompleterMixin.js (core ComboBox? function), _ComboBoxMenu.js+_ListBase.js+_ListMouseMixin.js (scrolling list). Then combine these with some mobile specific parts (_ListTouchMixin.js) to create that does not use a template. Added a basic automated test AutoCompleterMixin?.html.

comment:2 Changed 11 years ago by Douglas Hays

(In [23981]) References #12368. Add claro CSS for ComboBox? hovering and

workaround dojo.query anomaly where selected option elements are only found when the child ">" css selector is specified.

comment:3 Changed 11 years ago by Douglas Hays

(In [23986]) Refs #12393. Merge _ComboBoxValueMixin into _AutoCompleterMixin. Added optional item parameter to _setValueAttr so that _setItemAttr can call it and have this.inherited take the value all the way down to each superclass.

comment:4 Changed 11 years ago by bill

(In [24092]) just fixing some typos/spacing, refs #12393 !strict

comment:5 Changed 11 years ago by bill

(In [24631]) Fix requires (in particular, _FormWidget wasn't needed, and was pulling in _Widget and then everything in dijit/_base), refs #12393 !strict.

comment:6 Changed 11 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.