Opened 9 years ago

Closed 9 years ago

Last modified 7 years ago

#12375 closed defect (fixed)

refactor dijit.form.Textarea to create a lighter dojox.mobile.ExpandingTextArea

Reported by: Douglas Hays Owned by: Douglas Hays
Priority: high Milestone: 1.7
Component: Dijit - Form Version: 1.6.0
Keywords: 1.7-mobile Cc: Shane O'Sullivan
Blocked By: Blocking:

Description


Change History (8)

comment:1 Changed 9 years ago by Douglas Hays

Resolution: → fixed
Status: new → closed

(In [23959]) Fixes #12375. Refactor dijit.form.TextArea? by splitting out the core function into _ExpandingTextAreaMixin.js. Create dojox.mobile.ExpandingTextArea? from this mixin and without the _Templated dependency. Also create dojox.mobile.TextArea? as a thin wrapper to an HTML textarea so that MVC works. Added a basic automated test ExpandingTextAreaMixin?.html.

comment:2 Changed 9 years ago by Douglas Hays

Keywords: 1.7-mobile added

comment:3 Changed 9 years ago by bill

Component: Dijit → Dijit - Form

comment:4 Changed 9 years ago by bill

Resolution: fixed
Status: closed → reopened

I just tried ExpandingTextAreaMixin.html on IE8, both on trunk and back in [23959]. I'm getting test failures like: 

LOG: debug: 	_AssertFailure: doh._AssertFailure: assertEqual() failed:
	expected
		20
	but got
		null

 with hint: 
		dijit original maxLength

comment:5 Changed 9 years ago by Douglas Hays

Resolution: → fixed
Status: reopened → closed

(In [25998]) Fixes #12375. Non-webkit browsers don't support maxLength natively so don't test for it.

comment:6 Changed 9 years ago by Douglas Hays

In [26016]:

Refs #12375. Change test to work with IE8

comment:7 Changed 8 years ago by bill

In [28397]:

Use standard has.add()/has() for feature detection wraping. Refs #12375 !strict.

comment:8 Changed 7 years ago by bill

In [30875]:

use proper API to set widget value, refs #12375

Note: See TracTickets for help on using tickets.