Opened 8 years ago

Closed 6 years ago

#12371 closed defect (patchwelcome)

QueryReadStore pagination updating broken past the first page

Reported by: JimG Owned by: Bryan Forbes
Priority: high Milestone: tbd
Component: DojoX Grid Version: 1.4.3
Keywords: DataGrid QueryReadStore Cc:
Blocked By: Blocking:

Description

With a dojox.grid.DataGrid? connected to a dojox.data.QueryReadStore? with pagination enabled, nothing beyond the first page of data gets updated when the grid is filtered following an update. Using Firebug in FireFox? 3.6.13 I can see that whichever row is updated in the grid, the xhrGet request always has the start parameter set to 0.

The problem is that DataGrid.filter does not pass any parameters to DataGrid._fetch, which has a start parameter to be used in pagination.

To fix this locally I have modified the DataGrid.filter function to accept start as a third parameter and pass this on to the DataGrid._fetch function.

Starting at line 402 in DataGrid?.js:

    filter: function(query, reRender, start){
		this.query = query;
		if(reRender){
			this._clearData();
		}
		this._fetch(start);
	},

If reRender is true then the whole grid is refreshed anyway, so I'm not sure if it's worth handling start any differently in that case.

Change History (4)

comment:1 Changed 8 years ago by Bryan Forbes

Owner: changed from bryanforbes to Bryan Forbes

comment:2 Changed 8 years ago by JimG

The same issue exists in version 1.6.1.

comment:3 Changed 6 years ago by bill

DojoX Grid and EnhancedGrid are deprecated in favor of dgrid and gridx.

You should upgrade your code to use one of those two grids.

We will consider patches to the old DojoX Grid code though.

comment:4 Changed 6 years ago by bill

Resolution: patchwelcome
Status: newclosed
Note: See TracTickets for help on using tickets.