Opened 8 years ago

Closed 8 years ago

Last modified 6 years ago

#12368 closed defect (fixed)

refactor dijit.form.TextBox to create a lighter dojox.mobile.TextBox

Reported by: Douglas Hays Owned by: Douglas Hays
Priority: high Milestone: 1.7
Component: Dijit - Form Version: 1.6.0
Keywords: 1.7-mobile Cc: Shane O'Sullivan
Blocked By: Blocking:

Description


Change History (16)

comment:1 Changed 8 years ago by Douglas Hays

Resolution: → fixed
Status: new → closed

(In [23945]) Fixes #12368. Refactor dijit.form.TextBox? by splitting out the core function into _TextBoxMixin.js. Also split out most of _FormWidget.js into _FormWidgetMixin.js to remove the _Templated dependency. Combine these mixin's to create dojox.mobile.TextBox?. Added a basic automated test TextBoxMixin?.html.

comment:2 Changed 8 years ago by Douglas Hays

Cc: Shane O'Sullivan added

comment:3 Changed 8 years ago by Douglas Hays

(In [23948]) References #12368. Change ComboBox? and FilteringSelect? to not hard code in inheritance chains and to use this.inherited instead.

comment:4 Changed 8 years ago by Douglas Hays

(In [23967]) Refs #12368. Copy IE selection test code from original TextBox?.js to fix a failure in robot/ValidationTextBox.html

comment:5 Changed 8 years ago by Douglas Hays

(In [23981]) References #12368. Add claro CSS for ComboBox? hovering and workaround dojo.query anomaly where selected option elements are only found when the child ">" css selector is specified.

comment:6 Changed 8 years ago by Douglas Hays

Last comment meant for #12393

comment:7 Changed 8 years ago by bill

(In [23991]) The _setTypeAttr: null setting should only be for templated widgets (where the template has ${type}). If it's inherited into dojox.mobile.TextBox then it will break programmatic creation (i.e. the widget will be created but the user-specified type will be ignored).

Also removing some duplicated comments.

Refs #12368 !strict.

comment:8 Changed 8 years ago by Douglas Hays

(In [24012]) Refs #12368. Deprecate dojox.mobile.app.TextBox? in favor of dojox.mobile.TextBox? so that MVC works for those widgets.

comment:9 Changed 8 years ago by Douglas Hays

(In [24034]) Refs #12368. Remove dependency on dijit.focus from dijit.selectInputText

comment:10 Changed 8 years ago by Douglas Hays

(In [24035]) Refs #12368. Split out wai.js into _waiMixin.js so that it can be included in mobile TextBox? widgets without the high-contrast test.

comment:11 Changed 8 years ago by Douglas Hays

(In [24173]) Refs #12368. Handle random exception on IE when element focus fails.

comment:12 Changed 8 years ago by bill

(In [24577]) Make top level module for high-contrast mode detection (analogous to dojo/uacss), and delete _waiMixin.js (created in [24035], refs #12368), moving that deprecated code back into wai.js. Fixes #12823 !strict.

For backwards compatibility reasons dijit/_base/wai.js loads dijit/hccss.js

comment:13 Changed 8 years ago by bill

Component: Dijit → Dijit - Form

comment:14 Changed 7 years ago by bill

In [29917]:

Make border show up for hovered item in Menu, same as it does for Select and ComboBox's drop down menu. Fixes #15634. Still needs cleanup around (pre-existing) hardcoded colors in Menu.less that slipped in in [23981], refs #12368.

comment:15 Changed 7 years ago by bill

In [29918]:

Remove hardcoded colors. Refs #12368, #15634.

comment:16 Changed 6 years ago by bill

In [30877]:

just updating comments, refs #12368 !strict

Note: See TracTickets for help on using tickets.