Opened 9 years ago

Closed 8 years ago

#12359 closed enhancement (fixed)

Change to AMD for all Grid componoents

Reported by: evan Owned by: evan
Priority: high Milestone: 1.7
Component: DojoX Grid Version: 1.6.0rc1
Keywords: grid, AMD Cc: chuckd@…
Blocked By: Blocking:

Description

Using this ticket to track: "changing to AMD for all Grid components"

Attachments (1)

Grid_AMD_Fixes_1.6.0b2.zip (96.5 KB) - added by evan 9 years ago.
Fixes from Chuck(IBM, CCLA), enabling AMD for components of DataGrid/TreeGrid?

Download all attachments as: .zip

Change History (9)

Changed 9 years ago by evan

Attachment: Grid_AMD_Fixes_1.6.0b2.zip added

Fixes from Chuck(IBM, CCLA), enabling AMD for components of DataGrid/TreeGrid?

comment:1 Changed 8 years ago by evan

Resolution: fixed
Status: newclosed

(In [24459]) Fixes #12359 change to new AMD/define() syntax for all Grid components, refs #12672, !strict.

comment:2 Changed 8 years ago by bill

(In [24963]) Remove stray dojo.provide(), refs #12359, #12672, !strict.

comment:3 Changed 8 years ago by liucougar

(In [25034]) refs #12359: added missing dependency

!strict

comment:4 Changed 8 years ago by evan

(In [25197]) Refs #12359 !strict use dojo/text!./... to load template files

comment:5 Changed 8 years ago by evan

(In [25516]) Refs #12359 !strict fix 1 miss-converted dojo.require(...) which breaks all EDG test cases in nightly build(2011.6.14)

comment:6 Changed 8 years ago by bill

Resolution: fixed
Status: closedreopened

I noticed LazyTreeGrid is missing many dependencies, such as dijit/_Widget, and it's not in baseless format (ie, still lots of references to dojo and dijit globals).

Also, the other files have a few reference to "dijit/_base/manager", which is OK, but it's better to reference "dijit/registry" directly.

comment:7 Changed 8 years ago by evan

In [26187]:

Refs #12359 !strict change "dijit/_base/manager" to "dijit/registry" and "dijit/a11y"

comment:8 Changed 8 years ago by evan

Resolution: fixed
Status: reopenedclosed

Thanks Bill,

LazyTreeGrid? is the one still not finished, btw, I'm closing this and use #13542 to track all baseless and module return value for Grid

Note: See TracTickets for help on using tickets.